RESOLVED FIXED 97934
[Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver 
https://bugs.webkit.org/show_bug.cgi?id=97934
Summary [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits ...
Adam Barth
Reported 2012-09-28 13:23:28 PDT
[Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver
Attachments
Patch (4.67 KB, patch)
2012-09-28 13:25 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-28 13:25:22 PDT
Created attachment 166304 [details] Patch
James Robinson
Comment 2 2012-09-28 13:44:29 PDT
Comment on attachment 166304 [details] Patch It's as if a thousand unexplainable m_frame crash reports from the past cried out, but were suddenly silenced.
Leandro Graciá Gil
Comment 3 2012-09-28 13:50:56 PDT
Thanks for this fix Adam. I'm very glad to see this simplified.
Adam Barth
Comment 4 2012-09-28 13:53:13 PDT
(In reply to comment #3) > Thanks for this fix Adam. I'm very glad to see this simplified. Thanks for the idea to add the base class! It's so obvious in retrospect.
WebKit Review Bot
Comment 5 2012-09-28 13:56:54 PDT
Comment on attachment 166304 [details] Patch Clearing flags on attachment: 166304 Committed r129947: <http://trac.webkit.org/changeset/129947>
WebKit Review Bot
Comment 6 2012-09-28 13:56:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.