Bug 97934 - [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver
Summary: [Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 13:23 PDT by Adam Barth
Modified: 2012-09-28 13:56 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2012-09-28 13:25 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2012-09-28 13:23:28 PDT 
[Chromium] WebFrameImpl::m_frame is redundant now that WebFrameImpl inherits from FrameDestructionObserver
Comment 1 Adam Barth 2012-09-28 13:25:22 PDT 
Created attachment 166304 [details]
Patch
Comment 2 James Robinson 2012-09-28 13:44:29 PDT 
Comment on attachment 166304 [details]
Patch

It's as if a thousand unexplainable m_frame crash reports from the past cried out, but were suddenly silenced.
Comment 3 Leandro Graciá Gil 2012-09-28 13:50:56 PDT 
Thanks for this fix Adam. I'm very glad to see this simplified.
Comment 4 Adam Barth 2012-09-28 13:53:13 PDT 
(In reply to comment #3)
> Thanks for this fix Adam. I'm very glad to see this simplified.

Thanks for the idea to add the base class!  It's so obvious in retrospect.
Comment 5 WebKit Review Bot 2012-09-28 13:56:54 PDT 
Comment on attachment 166304 [details]
Patch

Clearing flags on attachment: 166304

Committed r129947: <http://trac.webkit.org/changeset/129947>
Comment 6 WebKit Review Bot 2012-09-28 13:56:57 PDT 
All reviewed patches have been landed.  Closing bug.