Bug 97919 - [chromium] Add fields to WebRenderingStats to track frequency of impl-thread vs. main-thread scrolling
Summary: [chromium] Add fields to WebRenderingStats to track frequency of impl-thread ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Terry Anderson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 08:59 PDT by Terry Anderson
Modified: 2012-10-02 09:49 PDT (History)
7 users (show)

See Also:


Attachments
Patch (2.44 KB, patch)
2012-09-28 09:01 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff
Patch (2.29 KB, patch)
2012-10-01 12:28 PDT, Terry Anderson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Terry Anderson 2012-09-28 08:59:43 PDT
Add |bool didImplThreadScroll| to WebRenderingStats.h which will be true if and only if we have impl-thread scrolled.
Comment 1 Terry Anderson 2012-09-28 09:01:11 PDT
Created attachment 166261 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-28 09:03:58 PDT
Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI.
Comment 3 Terry Anderson 2012-09-28 09:20:08 PDT
Corresponding chromium patch: https://codereview.chromium.org/10985082/
Comment 4 James Robinson 2012-09-28 12:30:36 PDT
Comment on attachment 166261 [details]
Patch

A bool isn't a good way to capture this.  What's the use case?  What about keeping counts of how many scroll-type input events resulted in scrolling vs ignoring vs sending to the main thread?
Comment 5 Terry Anderson 2012-10-01 12:28:32 PDT
Created attachment 166526 [details]
Patch
Comment 6 Terry Anderson 2012-10-01 12:31:28 PDT
(In reply to comment #4)
> (From update of attachment 166261 [details])
> A bool isn't a good way to capture this.  What's the use case?  What about keeping counts of how many scroll-type input events resulted in scrolling vs ignoring vs sending to the main thread?

We want to use this data to be able to track the frequency of impl-thread vs. main-thread scrolling, so I have added two counters instead of using a bool. The cumulative total of both counters will be reported each time renderingStats() is called.
Comment 7 James Robinson 2012-10-01 15:49:10 PDT
Comment on attachment 166526 [details]
Patch

R=me

We should figure out a way to route stats like this without involving WebKit patches
Comment 8 WebKit Review Bot 2012-10-02 09:49:36 PDT
Comment on attachment 166526 [details]
Patch

Clearing flags on attachment: 166526

Committed r130180: <http://trac.webkit.org/changeset/130180>
Comment 9 WebKit Review Bot 2012-10-02 09:49:39 PDT
All reviewed patches have been landed.  Closing bug.