Bug 97896 – YYDEBUG doesn't print token values

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Glenn Adams]

When debugging CSS lexer/parser with YYDEBUG set to 1, token values are not output because YYPRINT macro is a NO-OP.

[Glenn Adams]

Created attachment 166222 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 166222 [details]
Patch

Does this have any behavior or performance implications?

[Glenn Adams]

(In reply to comment #2)
> (From update of attachment 166222 [details])
> Does this have any behavior or performance implications?

no; YYDEBUG is defined as 0 in CSSGrammar.y and CSSParser.cpp at present; in order to use YYDEBUG feature, e.g., for special debugging, one has to explicitly change the setting of YYDEBUG to 1 in these two files; if one does define as 1, then normal YYDEBUG functions work as expected except that token values aren't printed; this patch simply enables output of token values when one sets YYDEBUG to 1;

[WebKit Review Bot]

Comment on attachment 166222 [details]
Patch

Clearing flags on attachment: 166222

Committed r130063: <http://trac.webkit.org/changeset/130063>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 166222 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166222&action=review

> Source/WebCore/css/CSSGrammar.y:1744
> +        YYFPRINTF(yyoutput, "%s", ((String)yyvalue.string).utf8().data());

I suggest function-call-style casting rather than C-style casting. String(yyvalue.string).utf8().data().