Bug 97889 - Port SimpleFontDataWin.cpp to WinCE
Summary: Port SimpleFontDataWin.cpp to WinCE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 04:18 PDT by Patrick R. Gansterer
Modified: 2012-11-13 11:31 PST (History)
1 user (show)

See Also:

Attachments
Patch (5.03 KB, patch)
2012-09-28 04:26 PDT, Patrick R. Gansterer 		buildbot: commit-queue-
Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2012-09-28 05:08 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-09-28 04:18:03 PDT 
Port SimpleFontDataWin.cpp to WinCE
Comment 1 Patrick R. Gansterer 2012-09-28 04:26:50 PDT 
Created attachment 166204 [details]
Patch
Comment 2 Patrick R. Gansterer 2012-09-28 04:28:15 PDT 
Comment on attachment 166204 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166204&action=review

> Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp:255
> +    GetTextExtentPoint32W(hdc, &c, 1, &fontSize);

It's the code from http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/wince/SimpleFontDataWinCE.cpp?rev=104545#L165
Comment 3 Build Bot 2012-09-28 04:49:43 PDT 
Comment on attachment 166204 [details]
Patch

Attachment 166204 [details] did not pass win-ews (win):
Output: http://queues.webkit.org/results/14066212
Comment 4 Patrick R. Gansterer 2012-09-28 05:08:23 PDT 
Created attachment 166217 [details]
Patch
Comment 5 Patrick R. Gansterer 2012-09-28 06:18:25 PDT 
Comment on attachment 166217 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166217&action=review

> Source/WebCore/platform/graphics/win/SimpleFontDataWin.cpp:255
> +    GetTextExtentPoint32W(hdc, &c, 1, &fontSize);

http://trac.webkit.org/browser/trunk/Source/WebCore/platform/graphics/wince/SimpleFontDataWinCE.cpp?rev=104545#L165
Comment 6 Brent Fulgham 2012-11-13 11:00:18 PST 
Comment on attachment 166217 [details]
Patch

Change looks good.  Thanks!
Comment 7 WebKit Review Bot 2012-11-13 11:31:48 PST 
Comment on attachment 166217 [details]
Patch

Clearing flags on attachment: 166217

Committed r134453: <http://trac.webkit.org/changeset/134453>
Comment 8 WebKit Review Bot 2012-11-13 11:31:51 PST 
All reviewed patches have been landed.  Closing bug.