Bug 97885 – Add parseDateTime, formatDateTime, and dateFormatText to Localizer

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Kent Tamura]

Add parseDateTime, formatDateTime, and dateFormatText to Localizer

[Kent Tamura]

Created attachment 166199 [details]
Patch

[WebKit Review Bot]

Comment on attachment 166199 [details]
Patch

Attachment 166199 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14064210

[Peter Beverloo (cr-android ews)]

Comment on attachment 166199 [details]
Patch

Attachment 166199 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14070180

[Kent Tamura]

Created attachment 166203 [details]
Patch 2

Fix ICU build

[Kent Tamura]

Comment on attachment 166203 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=166203&action=review

> Source/WebCore/ChangeLog:8
> +        This is a preparation to remove LocalizedData.h.

Oops, LocalizedData.h -> LocalizedDate.h

[Kentaro Hara]

Comment on attachment 166203 [details]
Patch 2

View in context: https://bugs.webkit.org/attachment.cgi?id=166203&action=review

Looks OK.

> Source/WebCore/platform/text/LocaleNone.cpp:71
> +    return ASCIILiteral("Year-Month-Day");

I'm not sure if this should be ASCIILiteral("Year-Month-Day") or String().

[Kent Tamura]

Thank you for reviewing.

(In reply to comment #6)
> > +    return ASCIILiteral("Year-Month-Day");
> 
> I'm not sure if this should be ASCIILiteral("Year-Month-Day") or String().

I'm sure it should be non-empty string showing acceptable date format. Actually this code is never used because all of ports with ENABLE_CALENDAR_PICKER use no LocaleNone.

[WebKit Review Bot]

Comment on attachment 166203 [details]
Patch 2

Rejecting attachment 166203 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2

Last 500 characters of output:
form/text/Localizer.h.rej
patching file Source/WebCore/platform/text/mac/LocaleMac.h
patching file Source/WebCore/platform/text/mac/LocaleMac.mm
patching file Source/WebCore/platform/text/mac/LocalizedDateMac.cpp
patching file Source/WebKit/chromium/tests/LocaleMacTest.cpp
patching file Source/WebKit/chromium/tests/LocaleWinTest.cpp

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--force', u'--reviewer', u'Kentaro Ha..." exit_code: 1 cwd: /mnt/git/webkit-commit-queue

Full output: http://queues.webkit.org/results/14059388

[Kent Tamura]

Committed r129912: <http://trac.webkit.org/changeset/129912>