Bug 97881 - [EFL][DRT] EFL DRT should disable visited links tracking by default
Summary: [EFL][DRT] EFL DRT should disable visited links tracking by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 03:11 PDT by Mikhail Pozdnyakov
Modified: 2012-09-28 04:14 PDT (History)
5 users (show)

See Also:

Attachments
patch (7.58 KB, patch)
2012-09-28 03:16 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch (6.94 KB, patch)
2012-09-28 03:19 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v2 (58.80 KB, patch)
2012-09-28 03:46 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
patch v3 (58.89 KB, patch)
2012-09-28 03:54 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-09-28 03:11:42 PDT 
EFL DRT should disable visited links tracking by default in order to be consistent with WKTR.
And thus both WK1 EFL and WK2 EFL can have similar results for fast/block/float/float-in-float-hit-testing.html
Comment 1 Mikhail Pozdnyakov 2012-09-28 03:16:32 PDT 
Created attachment 166191 [details]
patch
Comment 2 Mikhail Pozdnyakov 2012-09-28 03:17:21 PDT 
Comment on attachment 166191 [details]
patch

oops, left something uneeded in TestExpectations.
Comment 3 Mikhail Pozdnyakov 2012-09-28 03:19:15 PDT 
Created attachment 166192 [details]
patch
Comment 4 Chris Dumez 2012-09-28 03:25:49 PDT 
Comment on attachment 166192 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166192&action=review

> LayoutTests/platform/efl-wk2/TestExpectations:-194
> -# Visited link color is incorrect

I think there is at least one similar test in wk2 global Skipped list.

> LayoutTests/platform/efl/fast/block/float/float-in-float-hit-testing-expected.txt:22
> +            RenderInline {A} at (0,0) size 245x112 [color=#0000EE]

Pixel test rebaseline as well.

> Source/WebKit/efl/WebCoreSupport/DumpRenderTreeSupportEfl.h:110
> +

Useless extra line.
Comment 5 Mikhail Pozdnyakov 2012-09-28 03:46:25 PDT 
Created attachment 166196 [details]
patch v2

Comments from Chris are addressed.
Comment 6 Mikhail Pozdnyakov 2012-09-28 03:54:36 PDT 
Created attachment 166197 [details]
patch v3

Little corrections to TestExpectations and LayoutTests/ChangeLog.
Comment 7 Chris Dumez 2012-09-28 03:56:48 PDT 
Comment on attachment 166197 [details]
patch v3

LGTM.
Comment 8 WebKit Review Bot 2012-09-28 04:14:47 PDT 
Comment on attachment 166197 [details]
patch v3

Clearing flags on attachment: 166197

Committed r129874: <http://trac.webkit.org/changeset/129874>
Comment 9 WebKit Review Bot 2012-09-28 04:14:51 PDT 
All reviewed patches have been landed.  Closing bug.