Bug 97879 - Web Inspector: make HashSet memory instrumentation non-intrusive
Summary: Web Inspector: make HashSet memory instrumentation non-intrusive
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-28 02:59 PDT by Yury Semikhatsky
Modified: 2012-09-28 04:21 PDT (History)
12 users (show)

See Also:

Attachments
Patch (14.84 KB, patch)
2012-09-28 03:04 PDT, Yury Semikhatsky 		vsevik: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-09-28 02:59:19 PDT 
Declaring reportMemoryUsage as a friend of HashSet and HashTable is considered harmful, so we should switch to using only public API of the classes. This way we will still be able to collect necessary information. The problem is that it will be easier to change the implementation and forget to update the instrumentation(which is probably fine since these classes don't change often), also we won't be able to automatically mark corresponding objects in the memory as instrumented while checking correctness of the memory instrumentation.
Comment 1 Yury Semikhatsky 2012-09-28 03:04:19 PDT 
Created attachment 166187 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-09-28 03:09:01 PDT 
Comment on attachment 166187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166187&action=review

lgtm

> Source/WebKit/chromium/ChangeLog:8
> +        Updatee the test for HashSet memory instrumentation. We don't add

typo: Updatee
Comment 3 Yury Semikhatsky 2012-09-28 04:15:52 PDT 
Comment on attachment 166187 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166187&action=review

>> Source/WebKit/chromium/ChangeLog:8
>> +        Updatee the test for HashSet memory instrumentation. We don't add
> 
> typo: Updatee

Done.
Comment 4 Yury Semikhatsky 2012-09-28 04:21:33 PDT 
Committed r129875: <http://trac.webkit.org/changeset/129875>