Bug 97864 - [Forms] Adding DateTimeMonthFieldElement and DateTimeYearFieldElement
Summary: [Forms] Adding DateTimeMonthFieldElement and DateTimeYearFieldElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 97299
  Show dependency tree / graph
 
Reported: 2012-09-27 22:35 PDT by yosin
Modified: 2012-09-28 00:03 PDT (History)
1 user (show)

See Also:

Attachments
Patch 1 (14.28 KB, patch)
2012-09-27 23:50 PDT, yosin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-09-27 22:35:10 PDT 
To implement multiple fields "month" input UI, we would like to have DateTimeMonthFieldElement and DateTimeYearFieldElement
Comment 1 yosin 2012-09-27 23:50:10 PDT 
Created attachment 166153 [details]
Patch 1
Comment 2 yosin 2012-09-27 23:50:46 PDT 
Comment on attachment 166153 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-09-28 00:01:48 PDT 
Comment on attachment 166153 [details]
Patch 1

View in context: https://bugs.webkit.org/attachment.cgi?id=166153&action=review

> Source/WebCore/ChangeLog:26
> +        Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME
> +        and ENABLE_INPUT_MULTIPLE_FIELDS_UI.

Looks wrong.  INPUT_TYPE_TIME is unrelated.

> Source/WebCore/ChangeLog:52
> +        (WebCore::DateTimeNumericFieldElement::stepDown): Changed to use defaultValueForStepDown instead of maximum field value.
> +        (WebCore::DateTimeNumericFieldElement::stepUp):  Changed to use defaultValueForStepUp minium field value.
> +        (WebCore::DateTimeNumericFieldElement::value): Changed to use "%04d" when maximum field value is greater than 999 for year field.

They should be "why" comments.  "what" comments are not helpful in many cases.
Comment 4 yosin 2012-09-28 00:03:10 PDT 
Comment on attachment 166153 [details]
Patch 1

Clearing flags on attachment: 166153

Committed r129855: <http://trac.webkit.org/changeset/129855>
Comment 5 yosin 2012-09-28 00:03:15 PDT 
All reviewed patches have been landed.  Closing bug.