RESOLVED FIXED 97864
[Forms] Adding DateTimeMonthFieldElement and DateTimeYearFieldElement
https://bugs.webkit.org/show_bug.cgi?id=97864
Summary [Forms] Adding DateTimeMonthFieldElement and DateTimeYearFieldElement
yosin
Reported 2012-09-27 22:35:10 PDT
To implement multiple fields "month" input UI, we would like to have DateTimeMonthFieldElement and DateTimeYearFieldElement
Attachments
Patch 1 (14.28 KB, patch)
2012-09-27 23:50 PDT, yosin
no flags
yosin
Comment 1 2012-09-27 23:50:10 PDT
yosin
Comment 2 2012-09-27 23:50:46 PDT
Comment on attachment 166153 [details] Patch 1 Could you review this patch? Thanks in advance.
Kent Tamura
Comment 3 2012-09-28 00:01:48 PDT
Comment on attachment 166153 [details] Patch 1 View in context: https://bugs.webkit.org/attachment.cgi?id=166153&action=review > Source/WebCore/ChangeLog:26 > + Note: This patch affects ports which enable both ENABLE_INPUT_TYPE_TIME > + and ENABLE_INPUT_MULTIPLE_FIELDS_UI. Looks wrong. INPUT_TYPE_TIME is unrelated. > Source/WebCore/ChangeLog:52 > + (WebCore::DateTimeNumericFieldElement::stepDown): Changed to use defaultValueForStepDown instead of maximum field value. > + (WebCore::DateTimeNumericFieldElement::stepUp): Changed to use defaultValueForStepUp minium field value. > + (WebCore::DateTimeNumericFieldElement::value): Changed to use "%04d" when maximum field value is greater than 999 for year field. They should be "why" comments. "what" comments are not helpful in many cases.
yosin
Comment 4 2012-09-28 00:03:10 PDT
Comment on attachment 166153 [details] Patch 1 Clearing flags on attachment: 166153 Committed r129855: <http://trac.webkit.org/changeset/129855>
yosin
Comment 5 2012-09-28 00:03:15 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.