Bug 97818 - Results page should warn about time-dependent distributions
Summary: Results page should warn about time-dependent distributions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 77037
  Show dependency tree / graph
 
Reported: 2012-09-27 13:28 PDT by Ryosuke Niwa
Modified: 2012-09-27 16:23 PDT (History)
6 users (show)

See Also:

Attachments
WIP Demo (23.36 KB, text/html)
2012-09-27 13:29 PDT, Ryosuke Niwa 		no flags Details
WIP Demo (23.74 KB, text/html)
2012-09-27 13:30 PDT, Ryosuke Niwa 		no flags Details
Implements the feature (6.99 KB, patch)
2012-09-27 15:24 PDT, Ryosuke Niwa 		ojan: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Sample output (111.51 KB, text/html)
2012-09-27 15:25 PDT, Ryosuke Niwa 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2012-09-27 13:28:39 PDT 
We should automatically detect bugs like https://bugs.webkit.org/show_bug.cgi?id=97741 where test results follows a time-dependent distribution.
Comment 1 Ryosuke Niwa 2012-09-27 13:29:22 PDT 
Created attachment 166053 [details]
WIP Demo
Comment 2 Ryosuke Niwa 2012-09-27 13:30:18 PDT 
Created attachment 166055 [details]
WIP Demo
Comment 3 Ryosuke Niwa 2012-09-27 15:24:22 PDT 
Created attachment 166070 [details]
Implements the feature
Comment 4 Ryosuke Niwa 2012-09-27 15:25:10 PDT 
Created attachment 166071 [details]
Sample output
Comment 5 Ojan Vafai 2012-09-27 15:34:58 PDT 
Comment on attachment 166070 [details]
Implements the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=166070&action=review

> PerformanceTests/resources/results-template.html:304
> +        container.append('<div></div>');

Maybe put a title on these so that the mouseover tooltip can give some indication of what these are for?
Comment 6 Ojan Vafai 2012-09-27 15:36:04 PDT 
Comment on attachment 166070 [details]
Implements the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=166070&action=review

> PerformanceTests/resources/results-template.html:409
> +var warningSign = '<svg viewBox="0 0 100 100" style="width: 18px; height: 18px; vertical-align: bottom;" version="1.1">'

Or maybe put the title on this? It's confusing to have a warning icon without any explanation.
Comment 7 Ryosuke Niwa 2012-09-27 15:46:56 PDT 
Comment on attachment 166070 [details]
Implements the feature

View in context: https://bugs.webkit.org/attachment.cgi?id=166070&action=review

>> PerformanceTests/resources/results-template.html:409
>> +var warningSign = '<svg viewBox="0 0 100 100" style="width: 18px; height: 18px; vertical-align: bottom;" version="1.1">'
> 
> Or maybe put the title on this? It's confusing to have a warning icon without any explanation.

This svg element is wrapped in a span with a title. See line 442.
Comment 8 Build Bot 2012-09-27 15:49:55 PDT 
Comment on attachment 166070 [details]
Implements the feature

Attachment 166070 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14061028

New failing tests:
http/tests/workers/terminate-during-sync-operation.html
Comment 9 Ryosuke Niwa 2012-09-27 16:23:27 PDT 
Committed r129813: <http://trac.webkit.org/changeset/129813>