Bug 97814 - Add webkit_unit_tests to the flakiness dashboard
Summary: Add webkit_unit_tests to the flakiness dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 13:19 PDT by Julie Parent
Modified: 2012-09-27 15:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.28 KB, patch)
2012-09-27 13:20 PDT, Julie Parent 		no flags Details | Formatted Diff | Diff
Patch for landing (2.27 KB, patch)
2012-09-27 14:28 PDT, Julie Parent 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2012-09-27 13:19:03 PDT 
Add webkit_unit_tests to the flakiness dashboard
Comment 1 Julie Parent 2012-09-27 13:20:17 PDT 
Created attachment 166049 [details]
Patch
Comment 2 Julie Parent 2012-09-27 14:28:56 PDT 
Created attachment 166063 [details]
Patch for landing
Comment 3 WebKit Review Bot 2012-09-27 14:56:50 PDT 
Comment on attachment 166063 [details]
Patch for landing

Rejecting attachment 166063 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

ERROR: /mnt/git/webkit-commit-queue/Source/WebKit/mac/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/13967089
Comment 4 Adam Barth 2012-09-27 14:58:11 PDT 
Comment on attachment 166063 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=166063&action=review

> Tools/ChangeLog:6
> +        Reviewed by Dirk Pranke.

This line looks right.  I'm not sure why the bot complained.
Comment 5 Adam Barth 2012-09-27 15:00:50 PDT 
Comment on attachment 166063 [details]
Patch for landing

Clearing flags on attachment: 166063

Committed r129805: <http://trac.webkit.org/changeset/129805>
Comment 6 Adam Barth 2012-09-27 15:00:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Julie Parent 2012-09-27 15:02:02 PDT 
I just used webkit-patch land-safely, not sure why the changelog would have been incorrect. Thanks Adam!