Bug 97803 - Port DragDataWin.cpp to WinCE
Summary: Port DragDataWin.cpp to WinCE
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 10:50 PDT by Patrick R. Gansterer
Modified: 2012-11-20 11:07 PST (History)
5 users (show)

See Also:


Attachments
Patch (5.03 KB, patch)
2012-09-27 10:54 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff
Patch (5.33 KB, patch)
2012-09-28 04:39 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2012-09-27 10:50:29 PDT
Port DragDataWin.cpp to WinCE
Comment 1 Patrick R. Gansterer 2012-09-27 10:54:18 PDT
Created attachment 166031 [details]
Patch
Comment 2 Patrick R. Gansterer 2012-09-28 04:39:03 PDT
Created attachment 166207 [details]
Patch
Comment 3 Brent Fulgham 2012-11-19 23:08:35 PST
Comment on attachment 166207 [details]
Patch

Looks good to me.  You might need to land this manually, as it's been a while since you submitted the patch for review.
Comment 4 WebKit Review Bot 2012-11-19 23:14:05 PST
Comment on attachment 166207 [details]
Patch

Clearing flags on attachment: 166207

Committed r135255: <http://trac.webkit.org/changeset/135255>
Comment 5 WebKit Review Bot 2012-11-19 23:14:09 PST
All reviewed patches have been landed.  Closing bug.
Comment 6 Yury Semikhatsky 2012-11-19 23:51:28 PST
(In reply to comment #4)
> (From update of attachment 166207 [details])
> Clearing flags on attachment: 166207
> 
> Committed r135255: <http://trac.webkit.org/changeset/135255>

This change broke Chromium Win compilation: http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win%20Builder%20%28dbg%29/builds/31361

I landed fix in http://trac.webkit.org/changeset/135258
Comment 7 Brent Fulgham 2012-11-20 11:07:02 PST
Whoops! Patrick, looks like the various gyp files need to be gripped when removing files!