Patch to follow.
Created attachment 166160 [details] Patch
Comment on attachment 166160 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166160&action=review > Source/WebCore/inspector/InspectorController.h:96 > + void deviceMetricsOverrideUpdated(bool); This should not be exposed on the InspectorController. > Source/WebCore/inspector/InspectorOverlay.cpp:199 > + , m_deviceMetricsOverrideEnabled(false) Is webViewSize not enough? > Source/WebCore/inspector/InspectorOverlay.cpp:209 > + if (m_pausedInDebuggerMessage.isNull() && !m_highlightNode && !m_highlightRect && !m_deviceMetricsOverrideEnabled) I would use non-empty webViewSize as a flag. > Source/WebCore/inspector/InspectorOverlay.cpp:250 > +void InspectorOverlay::deviceMetricsOverrideUpdated(bool enabled) I don't think you need this method. > Source/WebCore/inspector/InspectorOverlay.cpp:368 > + gutterData->setBoolean("shouldShow", m_deviceMetricsOverrideEnabled); You don't need this flag.
Created attachment 166193 [details] Patch
Comment on attachment 166193 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166193&action=review > Source/WebCore/inspector/InspectorOverlay.cpp:240 > +void InspectorOverlay::webViewResized(const IntSize& size) resize > Source/WebCore/inspector/InspectorOverlay.cpp:242 > + m_webViewSize = size; m_size > Source/WebCore/inspector/InspectorOverlay.cpp:296 > + reset(visibleRect.size()); Lets pass both size and frameViewSize here. > Source/WebCore/inspector/InspectorOverlay.cpp:299 > + drawGutters(m_webViewSize.isEmpty() ? IntSize() : frameViewFullSize); Pass nothing here. > Source/WebCore/inspector/InspectorOverlayPage.html:289 > + var frameWidth = gutterData.frameWidth; window.frameViewSize.width > Source/WebCore/inspector/InspectorOverlayPage.html:293 > + rightGutter.style.display = ""; rightGutter.style.removeProperty("display")
Committed r129882: <http://trac.webkit.org/changeset/129882>
Re-opened since this is blocked by bug 97913
FYI, this also appears to have broken the following Chrome browser_tests on Mac and Linux: AutomationRendererHelperTest.ScrollingSnapshot AutomationRendererHelperTest.RTLSnapshot PrintWebViewHelperPreviewTest.PrintPreviewCenterToFitPage PrintWebViewHelperPreviewTest.PrintPreviewShrinkToFitPage. It's fixed with the revert obviously.
Re-landed as http://trac.webkit.org/changeset/130015.