Bug 97798 - Web Inspector: Elements: Show entities in edit as HTML.
Summary: Web Inspector: Elements: Show entities in edit as HTML.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: eustas.bug
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 09:31 PDT by eustas.bug
Modified: 2012-09-28 00:05 PDT (History)
13 users (show)

See Also:


Attachments
Patch (5.45 KB, patch)
2012-09-27 09:36 PDT, eustas.bug
no flags Details | Formatted Diff | Diff
Patch (5.50 KB, patch)
2012-09-27 23:29 PDT, eustas.bug
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2012-09-27 09:31:41 PDT
In elements tree entities like " ", " " are shown.
But in "Edit as HTML" mode they are substituted with Unicode chars.

For better consistency, these entities should be rendered the same
way both in tree and edit field.
Comment 1 eustas.bug 2012-09-27 09:36:40 PDT
Created attachment 166021 [details]
Patch
Comment 2 Alexander Pavlov (apavlov) 2012-09-27 22:10:22 PDT
Comment on attachment 166021 [details]
Patch

r=me
Comment 3 Alexander Pavlov (apavlov) 2012-09-27 22:16:22 PDT
Comment on attachment 166021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166021&action=review

> Source/WebCore/ChangeLog:9
> +        But in "Edit as HTML" mode they are substituted with Unicode chars.

nit: "substituted with" -> "replaced by" ("a substitute for ..." is something that comes into the game INSTEAD of something else)

> Source/WebCore/ChangeLog:14
> +        * inspector/front-end/ElementsTreeOutline.js: Entities unescaped.

This comment is not quite correct. Entity references are rendered in place of invisible characters in the "Edit as HTML" mode.
Comment 4 eustas.bug 2012-09-27 23:29:13 PDT
Created attachment 166149 [details]
Patch
Comment 5 eustas.bug 2012-09-27 23:29:44 PDT
Comment on attachment 166021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166021&action=review

>> Source/WebCore/ChangeLog:9
>> +        But in "Edit as HTML" mode they are substituted with Unicode chars.
> 
> nit: "substituted with" -> "replaced by" ("a substitute for ..." is something that comes into the game INSTEAD of something else)

Fixed.

>> Source/WebCore/ChangeLog:14
>> +        * inspector/front-end/ElementsTreeOutline.js: Entities unescaped.
> 
> This comment is not quite correct. Entity references are rendered in place of invisible characters in the "Edit as HTML" mode.

Fixed.
Comment 6 WebKit Review Bot 2012-09-28 00:05:00 PDT
Comment on attachment 166149 [details]
Patch

Clearing flags on attachment: 166149

Committed r129856: <http://trac.webkit.org/changeset/129856>
Comment 7 WebKit Review Bot 2012-09-28 00:05:04 PDT
All reviewed patches have been landed.  Closing bug.