RESOLVED FIXED 97798
Web Inspector: Elements: Show entities in edit as HTML. 
https://bugs.webkit.org/show_bug.cgi?id=97798
Summary Web Inspector: Elements: Show entities in edit as HTML.
eustas.bug
Reported 2012-09-27 09:31:41 PDT
In elements tree entities like " ", " " are shown. But in "Edit as HTML" mode they are substituted with Unicode chars. For better consistency, these entities should be rendered the same way both in tree and edit field.
Attachments
Patch (5.45 KB, patch)
2012-09-27 09:36 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Patch (5.50 KB, patch)
2012-09-27 23:29 PDT, eustas.bug 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
eustas.bug
Comment 1 2012-09-27 09:36:40 PDT
Created attachment 166021 [details] Patch
Alexander Pavlov (apavlov)
Comment 2 2012-09-27 22:10:22 PDT
Comment on attachment 166021 [details] Patch r=me
Alexander Pavlov (apavlov)
Comment 3 2012-09-27 22:16:22 PDT
Comment on attachment 166021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166021&action=review > Source/WebCore/ChangeLog:9 > + But in "Edit as HTML" mode they are substituted with Unicode chars. nit: "substituted with" -> "replaced by" ("a substitute for ..." is something that comes into the game INSTEAD of something else) > Source/WebCore/ChangeLog:14 > + * inspector/front-end/ElementsTreeOutline.js: Entities unescaped. This comment is not quite correct. Entity references are rendered in place of invisible characters in the "Edit as HTML" mode.
eustas.bug
Comment 4 2012-09-27 23:29:13 PDT
Created attachment 166149 [details] Patch
eustas.bug
Comment 5 2012-09-27 23:29:44 PDT
Comment on attachment 166021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=166021&action=review >> Source/WebCore/ChangeLog:9 >> + But in "Edit as HTML" mode they are substituted with Unicode chars. > > nit: "substituted with" -> "replaced by" ("a substitute for ..." is something that comes into the game INSTEAD of something else) Fixed. >> Source/WebCore/ChangeLog:14 >> + * inspector/front-end/ElementsTreeOutline.js: Entities unescaped. > > This comment is not quite correct. Entity references are rendered in place of invisible characters in the "Edit as HTML" mode. Fixed.
WebKit Review Bot
Comment 6 2012-09-28 00:05:00 PDT
Comment on attachment 166149 [details] Patch Clearing flags on attachment: 166149 Committed r129856: <http://trac.webkit.org/changeset/129856>
WebKit Review Bot
Comment 7 2012-09-28 00:05:04 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.