RESOLVED FIXED 97777
[Qt] Decide when to apply a scrolled position to the viewport based on the rect covered by the tiles 
https://bugs.webkit.org/show_bug.cgi?id=97777
Summary [Qt] Decide when to apply a scrolled position to the viewport based on the re...
Jocelyn Turcotte
Reported 2012-09-27 06:03:31 PDT
[Qt] Decide when to apply a scrolled position to the viewport based on the rect covered by the tiles
Attachments
Patch (18.43 KB, patch)
2012-09-27 06:09 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (18.69 KB, patch)
2012-09-27 09:08 PDT, Jocelyn Turcotte 		kenneth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2012-09-27 06:09:34 PDT
Created attachment 165984 [details] Patch
Kenneth Rohde Christiansen
Comment 2 2012-09-27 08:03:53 PDT
Comment on attachment 165984 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165984&action=review > Source/WebCore/platform/graphics/TiledBackingStore.cpp:263 > + m_coverRect = coverRect; > setKeepRect(keepRect); Why not add a setCoverRect for completion sake... > Source/WebCore/platform/graphics/TiledBackingStore.h:75 > + IntRect coveredRect() const { return m_coverRect; } Do you know that this is in fact covered? why not just call it coverRect() ? More might be covered than this. Also why are we not looking at visibleRect. coverRect could be mouch bigger than needed
Jocelyn Turcotte
Comment 3 2012-09-27 08:58:05 PDT
(In reply to comment #2) > > Source/WebCore/platform/graphics/TiledBackingStore.h:75 > > + IntRect coveredRect() const { return m_coverRect; } > > Do you know that this is in fact covered? why not just call it coverRect() ? More might be covered than this. Also why are we not looking at visibleRect. coverRect could be mouch bigger than needed It's not covered at this point, and I'm renaming it to coverRect() and tileCoverRect() to reflect this. It is covered after syncCompositingState() has been called on each layer so I'll keep it named tileCoveredRect from that point. What I want to know it, am I going to see any content at all if I scroll the viewport to this position, or just white/checkerboard? So the contract is that at least coverRect() will be covered, and that's what I need.
Jocelyn Turcotte
Comment 4 2012-09-27 09:08:21 PDT
Created attachment 166012 [details] Patch Rename coveredRect to coverRect from WebCore up until the rendering is done and remove tile from e.g. tileCoveredRect. Also add TiledBackingStore::setCoverRect
Jocelyn Turcotte
Comment 5 2012-10-01 04:38:18 PDT
Committed r130031: <http://trac.webkit.org/changeset/130031>
Note You need to log in before you can comment on or make changes to this bug.