Bug 97777 - [Qt] Decide when to apply a scrolled position to the viewport based on the rect covered by the tiles
: [Qt] Decide when to apply a scrolled position to the viewport based on the re...
Status: RESOLVED FIXED
: WebKit
New Bugs
: 528+ (Nightly build)
: Unspecified Unspecified
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2012-09-27 06:03 PST by
Modified: 2012-10-01 04:38 PST (History)


Attachments
Patch (18.43 KB, patch)
2012-09-27 06:09 PST, Jocelyn Turcotte
no flags Review Patch | Details | Formatted Diff | Diff
Patch (18.69 KB, patch)
2012-09-27 09:08 PST, Jocelyn Turcotte
kenneth: review+
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2012-09-27 06:03:31 PST
[Qt] Decide when to apply a scrolled position to the viewport based on the rect covered by the tiles
------- Comment #1 From 2012-09-27 06:09:34 PST -------
Created an attachment (id=165984) [details]
Patch
------- Comment #2 From 2012-09-27 08:03:53 PST -------
(From update of attachment 165984 [details])
View in context: https://bugs.webkit.org/attachment.cgi?id=165984&action=review

> Source/WebCore/platform/graphics/TiledBackingStore.cpp:263
> +    m_coverRect = coverRect;
>      setKeepRect(keepRect);

Why not add a setCoverRect for completion sake...

> Source/WebCore/platform/graphics/TiledBackingStore.h:75
> +    IntRect coveredRect() const { return m_coverRect; }

Do you know that this is in fact covered? why not just call it coverRect() ? More might be covered than this. Also why are we not looking at visibleRect. coverRect could be mouch bigger than needed
------- Comment #3 From 2012-09-27 08:58:05 PST -------
(In reply to comment #2)
> > Source/WebCore/platform/graphics/TiledBackingStore.h:75
> > +    IntRect coveredRect() const { return m_coverRect; }
> 
> Do you know that this is in fact covered? why not just call it coverRect() ? More might be covered than this. Also why are we not looking at visibleRect. coverRect could be mouch bigger than needed

It's not covered at this point, and I'm renaming it to coverRect() and tileCoverRect() to reflect this. It is covered after syncCompositingState() has been called on each layer so I'll keep it named tileCoveredRect from that point.

What I want to know it, am I going to see any content at all if I scroll the viewport to this position, or just white/checkerboard? So the contract is that at least coverRect() will be covered, and that's what I need.
------- Comment #4 From 2012-09-27 09:08:21 PST -------
Created an attachment (id=166012) [details]
Patch

Rename coveredRect to coverRect from WebCore up until the rendering is done and remove tile from e.g. tileCoveredRect.
Also add TiledBackingStore::setCoverRect
------- Comment #5 From 2012-10-01 04:38:18 PST -------
Committed r130031: <http://trac.webkit.org/changeset/130031>