WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97770
[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEflFullscreen.css
https://bugs.webkit.org/show_bug.cgi?id=97770
Summary
[EFL] Remove duplicated CSS between mediaControlsEfl.css and mediaControlsEfl...
Chris Dumez
Reported
2012-09-27 03:36:24 PDT
Some CSS rules are duplicated between mediaControlsEfl.css and mediaControlsEflFullscreen.css for no reason. This is an issue because it is easy to update mediaControlsEfl.css and forget to make the same update to mediaControlsEflFullscreen.css. As a matter of fact, the timeline display in fullscreen is currently off by a few pixels because its fullscreen CSS is not in sync with what is in mediaControlsEfl.css. We need to include in mediaControlsEflFullscreen.css only the CSS rules that are specific to fullscreen mode, that is to say, the hiding of some controls.
Attachments
Patch
(3.56 KB, patch)
2012-09-27 03:41 PDT
,
Chris Dumez
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Chris Dumez
Comment 1
2012-09-27 03:41:02 PDT
Created
attachment 165968
[details]
Patch
WebKit Review Bot
Comment 2
2012-09-27 04:45:46 PDT
Comment on
attachment 165968
[details]
Patch Clearing flags on attachment: 165968 Committed
r129754
: <
http://trac.webkit.org/changeset/129754
>
WebKit Review Bot
Comment 3
2012-09-27 04:45:50 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug