Bug 97766 - [WK2] Injected bundle API implementation should use toWTFString()
Summary: [WK2] Injected bundle API implementation should use toWTFString()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mikhail Pozdnyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-27 01:17 PDT by Mikhail Pozdnyakov
Modified: 2012-09-27 10:38 PDT (History)
8 users (show)

See Also:

Attachments
patch (16.18 KB, patch)
2012-09-27 01:25 PDT, Mikhail Pozdnyakov 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Pozdnyakov 2012-09-27 01:17:51 PDT 
Injected bundle API implementations should call toWTFString() rather than convert WKStringRef and WKURLRef to their impls and then call string() method directly. Rational for that is:
1) safety (toWTFString checks the given pointer)
2) code readability
Comment 1 Mikhail Pozdnyakov 2012-09-27 01:25:13 PDT 
Created attachment 165949 [details]
patch
Comment 2 WebKit Review Bot 2012-09-27 02:32:18 PDT 
Comment on attachment 165949 [details]
patch

Clearing flags on attachment: 165949

Committed r129743: <http://trac.webkit.org/changeset/129743>
Comment 3 WebKit Review Bot 2012-09-27 02:32:22 PDT 
All reviewed patches have been landed.  Closing bug.