WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97766
[WK2] Injected bundle API implementation should use toWTFString()
https://bugs.webkit.org/show_bug.cgi?id=97766
Summary
[WK2] Injected bundle API implementation should use toWTFString()
Mikhail Pozdnyakov
Reported
2012-09-27 01:17:51 PDT
Injected bundle API implementations should call toWTFString() rather than convert WKStringRef and WKURLRef to their impls and then call string() method directly. Rational for that is: 1) safety (toWTFString checks the given pointer) 2) code readability
Attachments
patch
(16.18 KB, patch)
2012-09-27 01:25 PDT
,
Mikhail Pozdnyakov
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mikhail Pozdnyakov
Comment 1
2012-09-27 01:25:13 PDT
Created
attachment 165949
[details]
patch
WebKit Review Bot
Comment 2
2012-09-27 02:32:18 PDT
Comment on
attachment 165949
[details]
patch Clearing flags on attachment: 165949 Committed
r129743
: <
http://trac.webkit.org/changeset/129743
>
WebKit Review Bot
Comment 3
2012-09-27 02:32:22 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug