Bug 97756 - [Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeEditElement::EditControlOwner rather than containing
Summary: [Forms] BaseMultipleFieldsDateAndTimeInputType class should inherit DateTimeE...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on: 97521
Blocks:
  Show dependency treegraph
 
Reported: 2012-09-26 21:13 PDT by yosin
Modified: 2012-09-27 01:21 PDT (History)
3 users (show)

See Also:


Attachments
Patch 1 (9.02 KB, patch)
2012-09-27 00:08 PDT, yosin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-09-26 21:13:13 PDT
We used containment instead of inheritance for implementing DateTimeEditElement::EditControlOwner interface when we implemented in TimeInputType class to use BaseDateAndTimeInputType as base class of TimeInputType regardless single field UI or multiple fields UI.

Once we use different base class based on single field UI or multiple fields UI, we can put DateTimeEditElement::EditControlOwner interface into base class list of BaseMultipleFieldsDateAndTimeInputType class.
Comment 1 yosin 2012-09-27 00:08:27 PDT
Created attachment 165940 [details]
Patch 1
Comment 2 yosin 2012-09-27 00:10:45 PDT
Comment on attachment 165940 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-09-27 00:32:07 PDT
Comment on attachment 165940 [details]
Patch 1

ok
Comment 4 yosin 2012-09-27 01:21:43 PDT
Comment on attachment 165940 [details]
Patch 1

Clearing flags on attachment: 165940

Committed r129739: <http://trac.webkit.org/changeset/129739>
Comment 5 yosin 2012-09-27 01:21:47 PDT
All reviewed patches have been landed.  Closing bug.