WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97751
webkitpy: make warning about missing BUG identifiers per-port configurable
https://bugs.webkit.org/show_bug.cgi?id=97751
Summary
webkitpy: make warning about missing BUG identifiers per-port configurable
Dirk Pranke
Reported
2012-09-26 19:20:17 PDT
webkitpy: make warning about missing BUG identifiers per-port configurable
Attachments
Patch
(5.91 KB, patch)
2012-09-26 19:23 PDT
,
Dirk Pranke
ojan
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dirk Pranke
Comment 1
2012-09-26 19:23:24 PDT
Created
attachment 165917
[details]
Patch
Ojan Vafai
Comment 2
2012-09-26 21:31:05 PDT
Comment on
attachment 165917
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=165917&action=review
Seems like a reasonable path forward.
> Tools/Scripts/webkitpy/layout_tests/port/base.py:1005 > + def warn_if_bug_missing_in_test_expectations(self): > + return False > +
I assume this copy-paste was accidental?
Dirk Pranke
Comment 3
2012-09-27 10:13:42 PDT
Comment on
attachment 165917
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=165917&action=review
>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1005 >> + > > I assume this copy-paste was accidental?
whoops. Yes :).
Dirk Pranke
Comment 4
2012-09-27 11:59:53 PDT
Committed
r129784
: <
http://trac.webkit.org/changeset/129784
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug