Bug 97751 - webkitpy: make warning about missing BUG identifiers per-port configurable
Summary: webkitpy: make warning about missing BUG identifiers per-port configurable
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords:
Depends on:
Blocks: 97750
  Show dependency tree / graph
 
Reported: 2012-09-26 19:20 PDT by Dirk Pranke
Modified: 2012-09-27 11:59 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2012-09-26 19:23 PDT, Dirk Pranke 		ojan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-09-26 19:20:17 PDT 
webkitpy: make warning about missing BUG identifiers per-port configurable
Comment 1 Dirk Pranke 2012-09-26 19:23:24 PDT 
Created attachment 165917 [details]
Patch
Comment 2 Ojan Vafai 2012-09-26 21:31:05 PDT 
Comment on attachment 165917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165917&action=review

Seems like a reasonable path forward.

> Tools/Scripts/webkitpy/layout_tests/port/base.py:1005
> +    def warn_if_bug_missing_in_test_expectations(self):
> +        return False
> +

I assume this copy-paste was accidental?
Comment 3 Dirk Pranke 2012-09-27 10:13:42 PDT 
Comment on attachment 165917 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165917&action=review

>> Tools/Scripts/webkitpy/layout_tests/port/base.py:1005
>> +
> 
> I assume this copy-paste was accidental?

whoops. Yes :).
Comment 4 Dirk Pranke 2012-09-27 11:59:53 PDT 
Committed r129784: <http://trac.webkit.org/changeset/129784>