RESOLVED INVALID Bug 97748
testRunner.setFrameFlatteningEnabled only affects the main frame, not nested frames 
https://bugs.webkit.org/show_bug.cgi?id=97748
Summary testRunner.setFrameFlatteningEnabled only affects the main frame, not nested ...
Simon Fraser (smfr)
Reported 2012-09-26 18:31:12 PDT
I was trying to figure out why a frame flattening test didn't behave as I expected. It turns out that testRunner.setFrameFlatteningEnabled(true); only affects the main frame, not nested frames. This makes it impossible to use to compare with mobile devices which set that everywhere. Maybe testRunner.settings should always "go deep"?
Attachments
Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2012-09-26 21:25:12 PDT
testRunner.settings should change WebCore::Settings, which is per-page. I haven't looked into setFrameFlatteningEnabled, so I don't know what that does.
Kenneth Rohde Christiansen
Comment 2 2012-09-27 00:55:22 PDT
frame flattening kind of only makes sense if it is applied everywhere, thus also for nested frames, so it makes sense that that setting goes deep. Is it already inherited by new frames after the setting has been set?
Simon Fraser (smfr)
Comment 3 2012-09-27 09:01:03 PDT
I may have made a hasty assumption here. Will debug more this afternoon.
Alexey Proskuryakov
Comment 4 2012-09-27 09:28:40 PDT
Renaming to match bug description for now. I agree with Adam, original title does not seem accurate.
Simon Fraser (smfr)
Comment 5 2012-09-27 12:45:51 PDT
I'm debugging a test that navigates. m_frameFlatteningEnabled is false on the Page's Settings, but I'm not sure how it gets that way.
Simon Fraser (smfr)
Comment 6 2012-09-27 19:15:17 PDT
I was confused. See bug 97841 for what I was investigating.
Note You need to log in before you can comment on or make changes to this bug.