Currently we don't push all fonts listed in TestShellX11.cpp because we had been unable to override the fallback fonts of Android before until we had fallback_fonts.xml on Android. And also at that time some font files were too big for devices. Now Android has fallback font configuration mechanism, so we can push more fonts to better match chromium-linux expectations.
Created attachment 165911 [details] Patch
Comment on attachment 165911 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165911&action=review looks reasonable. > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:207 > + result = self._check_file_exists(self._path_to_md5sum(), 'md5sum unitily') and result Nit: typo 'unitily'.
Created attachment 166016 [details] Patch
(In reply to comment #2) > (From update of attachment 165911 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165911&action=review > > looks reasonable. > > > Tools/Scripts/webkitpy/layout_tests/port/chromium_android.py:207 > > + result = self._check_file_exists(self._path_to_md5sum(), 'md5sum unitily') and result > > Nit: typo 'unitily'. Done.
Comment on attachment 166016 [details] Patch Rejecting attachment 166016 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: 59019. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... LayoutTests/platform/chromium-android/TestExpectations:1: No port uses path LayoutTests/platform/chromium-android/TestExpectations for test_expectations [test/expectations] [5] Total errors found: 1 in 1 files Full output: http://queues.webkit.org/results/14032880
Created attachment 166025 [details] Patch for landing.
Comment on attachment 166025 [details] Patch for landing. Rejecting attachment 166025 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: flict in Source/WebCore/ChangeLog Failed to merge in the changes. Patch failed at 0001 Web Inspector: [REGRESSION] Breakpoints are not always shown in breakpoints sidebar pane. When you have resolved this problem run "git rebase --continue". If you would prefer to skip this patch, instead run "git rebase --skip". To restore the original branch and stop rebasing run "git rebase --abort". rebase refs/remotes/origin/master: command returned error: 1 Died at Tools/Scripts/update-webkit line 164. Full output: http://queues.webkit.org/results/14027991
Comment on attachment 166025 [details] Patch for landing. Rejecting attachment 166025 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154708 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 51>At revision 154708. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/14037869
Created attachment 166034 [details] Rebased
Comment on attachment 166034 [details] Rebased Clearing flags on attachment: 166034 Committed r129783: <http://trac.webkit.org/changeset/129783>
All reviewed patches have been landed. Closing bug.