Bug 97745 - [Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
Summary: [Cairo] Unnecessary creation of ShareableBitmap's for directly composited images
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2012-09-26 17:52 PDT by Helder Correia
Modified: 2012-09-27 12:44 PDT (History)
3 users (show)

See Also:

Patch (3.14 KB, patch)
2012-09-26 18:12 PDT, Helder Correia
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Helder Correia 2012-09-26 17:52:08 PDT
In LayerTreeCoordinator::adoptImageBackingStore(), there is a PLATFORM(QT) code path to check for identical images, but nothing is done for Cairo, which results in the occurrence of avoidable resource allocations. The issue happens in e.g. http://www.webkit.org/blog-files/leaves/, where there are many leaves flying around while they're produced out of only four bitmaps.
Comment 1 Helder Correia 2012-09-26 18:12:13 PDT
Created attachment 165908 [details]
Comment 2 WebKit Review Bot 2012-09-27 12:44:14 PDT
Comment on attachment 165908 [details]

Clearing flags on attachment: 165908

Committed r129791: <http://trac.webkit.org/changeset/129791>
Comment 3 WebKit Review Bot 2012-09-27 12:44:17 PDT
All reviewed patches have been landed.  Closing bug.