RESOLVED FIXED 97734
Proxy all the things! 
https://bugs.webkit.org/show_bug.cgi?id=97734
Summary Proxy all the things!
Gavin Barraclough
Reported 2012-09-26 15:35:54 PDT
To match WebCore's window shell.
Attachments
Fix (4.54 KB, patch)
2012-09-26 15:39 PDT, Gavin Barraclough 		oliver: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2012-09-26 15:39:15 PDT
Created attachment 165886 [details] Fix
Gavin Barraclough
Comment 2 2012-09-26 15:50:13 PDT
Fixed in r129711
Beth Dakin
Comment 3 2012-09-26 17:25:26 PDT
It looks like this change broke the Windows build. Here is the relevant output: 14>####### COMPILING 1 FILES USING AT MOST 8 PARALLEL INSTANCES OF cl.exe ########### 14>jsc.cpp 14>Performing Pre-Link Event... 14> 1 file(s) copied. 14> 1 file(s) copied. 14> 1 file(s) copied. 14> 1 file(s) copied. 14>Linking... 14>jsc.obj : error LNK2019: unresolved external symbol "protected: void __thiscall JSC::JSGlobalObject::setGlobalThis(class JSC::JSGlobalData &,class JSC::JSObject *)" (?setGlobalThis@JSGlobalObject@JSC@@IAEXAAVJSGlobalData@2@PAVJSObject@2@@Z) referenced in function "public: static class GlobalObject * __cdecl GlobalObject::create(class JSC::JSGlobalData &,class JSC::Structure *,class WTF::Vector<class WTF::String,0> const &)" (?create@GlobalObject@@SAPAV1@AAVJSGlobalData@JSC@@PAVStructure@3@ABV?$Vector@VString@WTF@@$0A@@WTF@@@Z) 14>C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\bin\jsc.exe : fatal error LNK1120: 1 unresolved externals 14>Build log was saved at "file://C:\cygwin\home\buildbot\slave\win-release\build\WebKitBuild\Release\obj\jsc\BuildLog.htm" 14>jsc - 2 error(s), 0 warning(s)
Note You need to log in before you can comment on or make changes to this bug.