Bug 97721 – [CSS Exclusions] Test that dynamically setting shape-inside causes relayout in child elements

• Status: RESOLVED
• Resolution: FIXED
• Component: CSS

[Bear Travis]

Make sure setting shape-inside causes relayout when children contain inline content
<div style="shape-inside:...">
<div>
I am inline content
</div>
</div>

[Bear Travis]

Created attachment 171342 [details]
Initial patch

[Dirk Schulze]

Comment on attachment 171342 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171342&action=review

> LayoutTests/fast/exclusions/resources/simple-rectangle.js:29
> +    if (content)
> +        elem.innerHTML = content;

This seems more then a restriction then an addition. Can you explain it in more detail what you aim to do and why you did it?

[Bear Travis]

The goal for this test is to add a shape-inside dynamically to an element with block children, and make sure it lays out correctly. The previous tests all added shape-inside and content at the same time, via the script.

The added conditional allows us to skip passing in a content argument, leaving the element's existing innerHTML in place. Does this make sense? Deserve a comment in the changelog or js file?

[WebKit Review Bot]

Comment on attachment 171342 [details]
Initial patch

Clearing flags on attachment: 171342

Committed r133106: <http://trac.webkit.org/changeset/133106>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.