Bug 97721 - [CSS Exclusions] Test that dynamically setting shape-inside causes relayout in child elements
Summary: [CSS Exclusions] Test that dynamically setting shape-inside causes relayout i...
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bear Travis
Depends on:
Blocks: 89256 97704
  Show dependency treegraph
Reported: 2012-09-26 13:11 PDT by Bear Travis
Modified: 2012-10-31 18:21 PDT (History)
2 users (show)

See Also:

Initial patch (4.94 KB, patch)
2012-10-29 17:14 PDT, Bear Travis
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Bear Travis 2012-09-26 13:11:04 PDT
Make sure setting shape-inside causes relayout when children contain inline content
<div style="shape-inside:...">
I am inline content
Comment 1 Bear Travis 2012-10-29 17:14:06 PDT
Created attachment 171342 [details]
Initial patch
Comment 2 Dirk Schulze 2012-10-31 06:23:56 PDT
Comment on attachment 171342 [details]
Initial patch

View in context: https://bugs.webkit.org/attachment.cgi?id=171342&action=review

> LayoutTests/fast/exclusions/resources/simple-rectangle.js:29
> +    if (content)
> +        elem.innerHTML = content;

This seems more then a restriction then an addition. Can you explain it in more detail what you aim to do and why you did it?
Comment 3 Bear Travis 2012-10-31 10:33:07 PDT
The goal for this test is to add a shape-inside dynamically to an element with block children, and make sure it lays out correctly. The previous tests all added shape-inside and content at the same time, via the script.

The added conditional allows us to skip passing in a content argument, leaving the element's existing innerHTML in place. Does this make sense? Deserve a comment in the changelog or js file?
Comment 4 WebKit Review Bot 2012-10-31 18:21:46 PDT
Comment on attachment 171342 [details]
Initial patch

Clearing flags on attachment: 171342

Committed r133106: <http://trac.webkit.org/changeset/133106>
Comment 5 WebKit Review Bot 2012-10-31 18:21:50 PDT
All reviewed patches have been landed.  Closing bug.