Bug 97719 - JSObject::ensureArrayStorage() ignores the possibility that extensions have been prevented
Summary: JSObject::ensureArrayStorage() ignores the possibility that extensions have b...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-26 12:52 PDT by Filip Pizlo
Modified: 2012-09-26 13:08 PDT (History)
1 user (show)

See Also:


Attachments
the patch (16.63 KB, patch)
2012-09-26 12:55 PDT, Filip Pizlo
barraclough: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-09-26 12:52:51 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2012-09-26 12:55:15 PDT
Created attachment 165857 [details]
the patch
Comment 2 WebKit Review Bot 2012-09-26 13:01:29 PDT
Attachment 165857 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1
Source/JavaScriptCore/runtime/JSObject.h:654:  The parameter name "globalData" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Filip Pizlo 2012-09-26 13:08:07 PDT
Landed in http://trac.webkit.org/changeset/129691