97687 – 4.95MB below RenderBlock::insertIntoTrackedRendererMaps() on Membuster3.

Bug 97687 - 4.95MB below RenderBlock::insertIntoTrackedRendererMaps() on Membuster3.

Summary: 4.95MB below RenderBlock::insertIntoTrackedRendererMaps() on Membuster3.

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	Layout and Rendering (show other bugs)
Version:	528+ (Nightly build)
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Andreas Kling

URL:
Keywords:	InRadar

Depends on:
Blocks:

Reported:	2012-09-26 08:25 PDT by Andreas Kling
Modified:	2012-09-26 12:10 PDT (History)
CC List:	4 users (show)

See Also:

Attachments
Patch (1.59 KB, patch) 2012-09-26 09:03 PDT, Andreas Kling	andersca: review+	Details \| Formatted Diff \| Diff
Patch for blending (1.59 KB, patch) 2012-09-26 11:04 PDT, Andreas Kling	webkit.review.bot: commit-queue-	Details \| Formatted Diff \| Diff
Less Anders, more landability. (1.59 KB, patch) 2012-09-26 11:43 PDT, Andreas Kling	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andreas Kling 2012-09-26 08:25:44 PDT

We currently have 4.95MB of allocations below this function on the Membuster3 benchmark.
I suspect it would be easy to reduce this by tweaking the ListHashSets used in the descendants map.

Comment 1 Radar WebKit Bug Importer 2012-09-26 08:26:07 PDT

<rdar://problem/12376748>

Comment 2 Andreas Kling 2012-09-26 09:03:42 PDT

Created attachment 165818 [details]
Patch

Comment 3 Anders Carlsson 2012-09-26 09:54:32 PDT

Comment on attachment 165818 [details]
Patch

Make it 16 and you've got yourself a deal!

Comment 4 Eric Seidel (no email) 2012-09-26 10:24:07 PDT

Thanks!

Comment 5 Andreas Kling 2012-09-26 11:04:08 PDT

Created attachment 165833 [details]
Patch for blending

Comment 6 WebKit Review Bot 2012-09-26 11:13:00 PDT

Comment on attachment 165833 [details]
Patch for blending

Rejecting attachment 165833 [details] from commit-queue.

Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1

Karl Anders Carlsson found in /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to committers.py.
ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).

Full output: http://queues.webkit.org/results/14033515

Comment 7 Eric Seidel (no email) 2012-09-26 11:20:50 PDT

Fancified reviewer names don't blend.

Comment 8 Andreas Kling 2012-09-26 11:41:51 PDT

(In reply to comment #7)
> Fancified reviewer names don't blend.

Aw dangit!

Comment 9 Andreas Kling 2012-09-26 11:43:07 PDT

Created attachment 165840 [details]
Less Anders, more landability.

Comment 10 WebKit Review Bot 2012-09-26 12:10:37 PDT

Comment on attachment 165840 [details]
Less Anders, more landability.

Clearing flags on attachment: 165840

Committed r129682: <http://trac.webkit.org/changeset/129682>

Comment 11 WebKit Review Bot 2012-09-26 12:10:41 PDT

All reviewed patches have been landed.  Closing bug.