Bug 97686 – run-perf-tests must expand environment variables in user provided paths

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Marcelo Lira]

Calling run-perf-tests using shell variables for paths values will result in errors when trying to open files using those paths.

Examples:

$ run-perf-tests --platform=qt --release --output-json-path=~/perf-results
$ run-perf-tests --platform=qt --release --output-json-path=$HOME/perf-results

'~' and '$HOME' don't get expanded, and further usages like the following will break:

codecs.open(path, 'w', 'utf-8')

Even worse in the case of the output path, because the error will happen only at the end of the long process of running the performance tests.

[Marcelo Lira]

Created attachment 165810 [details]
Patch

[Jesus Sanchez-Palencia]

(In reply to comment #1)
> Created an attachment (id=165810) [details]
> Patch

I can confirm the issue since I've faced it as well. (And it's quite annoying after you've been running tests for one hour or so.)

[Eric Seidel (no email)]

Comment on attachment 165810 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165810&action=review

> Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py:75
> +        def _expand_path(option, opt_str, value, parser):
> +            path = os.path.expandvars(os.path.expanduser(value))
> +            setattr(parser.values, option.dest, path)

Arguably this should use the Environment abstraction in webkitpy.common.  Otherwise, how do you test this?  It looks like currently you aren't... :)

[WebKit Review Bot]

Comment on attachment 165810 [details]
Patch

Clearing flags on attachment: 165810

Committed r129683: <http://trac.webkit.org/changeset/129683>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.