Bug 97683 - Web Inspector: expose debug memory instrumentation debug data through the protocol
Summary: Web Inspector: expose debug memory instrumentation debug data through the pro...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yury Semikhatsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-26 07:39 PDT by Yury Semikhatsky
Modified: 2012-09-27 00:57 PDT (History)
12 users (show)

See Also:

Attachments
Patch (5.33 KB, patch)
2012-09-26 07:43 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Patch (5.85 KB, patch)
2012-09-26 08:08 PDT, Yury Semikhatsky 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yury Semikhatsky 2012-09-26 07:39:42 PDT 
To add a test for memory instrumentation we need to be able to retrieve the number of instrumented objects and the number of instrumented objects that were not allocated by the memory allocator. The easiest way to achieve this is to expose these data as part of response to Memory.getProcessMemoryDistribution command.
Comment 1 Yury Semikhatsky 2012-09-26 07:43:33 PDT 
Created attachment 165799 [details]
Patch
Comment 2 Ilya Tikhonovsky 2012-09-26 08:02:37 PDT 
Comment on attachment 165799 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165799&action=review

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:543
> +        RefPtr<InspectorMemoryBlock> totalInstrumented = InspectorMemoryBlock::create().setName("TotalInstrumentedObjects");

TotalInstrumentedObjectsCount

> Source/WebCore/inspector/InspectorMemoryAgent.cpp:546
> +        RefPtr<InspectorMemoryBlock> incorrectlyInstrumented = InspectorMemoryBlock::create().setName("InstrumentedButNotAllocated");

InstrumentedButNotAllocatedObjectsCount
Comment 3 Ilya Tikhonovsky 2012-09-26 08:03:04 PDT 
otherwise lgtm
Comment 4 Yury Semikhatsky 2012-09-26 08:08:12 PDT 
Created attachment 165804 [details]
Patch
Comment 5 Yury Semikhatsky 2012-09-26 08:08:54 PDT 
(In reply to comment #2)
> (From update of attachment 165799 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165799&action=review
> 
> > Source/WebCore/inspector/InspectorMemoryAgent.cpp:543
> > +        RefPtr<InspectorMemoryBlock> totalInstrumented = InspectorMemoryBlock::create().setName("TotalInstrumentedObjects");
> 
> TotalInstrumentedObjectsCount
> 
Done.

> > Source/WebCore/inspector/InspectorMemoryAgent.cpp:546
> > +        RefPtr<InspectorMemoryBlock> incorrectlyInstrumented = InspectorMemoryBlock::create().setName("InstrumentedButNotAllocated");
> 
> InstrumentedButNotAllocatedObjectsCount
Done.
Comment 6 WebKit Review Bot 2012-09-27 00:57:32 PDT 
Comment on attachment 165804 [details]
Patch

Clearing flags on attachment: 165804

Committed r129734: <http://trac.webkit.org/changeset/129734>
Comment 7 WebKit Review Bot 2012-09-27 00:57:35 PDT 
All reviewed patches have been landed.  Closing bug.