RESOLVED FIXED Bug 97683
Web Inspector: expose debug memory instrumentation debug data through the protocol 
https://bugs.webkit.org/show_bug.cgi?id=97683
Summary Web Inspector: expose debug memory instrumentation debug data through the pro...
Yury Semikhatsky
Reported 2012-09-26 07:39:42 PDT
To add a test for memory instrumentation we need to be able to retrieve the number of instrumented objects and the number of instrumented objects that were not allocated by the memory allocator. The easiest way to achieve this is to expose these data as part of response to Memory.getProcessMemoryDistribution command.
Attachments
Patch (5.33 KB, patch)
2012-09-26 07:43 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Patch (5.85 KB, patch)
2012-09-26 08:08 PDT, Yury Semikhatsky 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Yury Semikhatsky
Comment 1 2012-09-26 07:43:33 PDT
Created attachment 165799 [details] Patch
Ilya Tikhonovsky
Comment 2 2012-09-26 08:02:37 PDT
Comment on attachment 165799 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165799&action=review > Source/WebCore/inspector/InspectorMemoryAgent.cpp:543 > + RefPtr<InspectorMemoryBlock> totalInstrumented = InspectorMemoryBlock::create().setName("TotalInstrumentedObjects"); TotalInstrumentedObjectsCount > Source/WebCore/inspector/InspectorMemoryAgent.cpp:546 > + RefPtr<InspectorMemoryBlock> incorrectlyInstrumented = InspectorMemoryBlock::create().setName("InstrumentedButNotAllocated"); InstrumentedButNotAllocatedObjectsCount
Ilya Tikhonovsky
Comment 3 2012-09-26 08:03:04 PDT
otherwise lgtm
Yury Semikhatsky
Comment 4 2012-09-26 08:08:12 PDT
Created attachment 165804 [details] Patch
Yury Semikhatsky
Comment 5 2012-09-26 08:08:54 PDT
(In reply to comment #2) > (From update of attachment 165799 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=165799&action=review > > > Source/WebCore/inspector/InspectorMemoryAgent.cpp:543 > > + RefPtr<InspectorMemoryBlock> totalInstrumented = InspectorMemoryBlock::create().setName("TotalInstrumentedObjects"); > > TotalInstrumentedObjectsCount > Done. > > Source/WebCore/inspector/InspectorMemoryAgent.cpp:546 > > + RefPtr<InspectorMemoryBlock> incorrectlyInstrumented = InspectorMemoryBlock::create().setName("InstrumentedButNotAllocated"); > > InstrumentedButNotAllocatedObjectsCount Done.
WebKit Review Bot
Comment 6 2012-09-27 00:57:32 PDT
Comment on attachment 165804 [details] Patch Clearing flags on attachment: 165804 Committed r129734: <http://trac.webkit.org/changeset/129734>
WebKit Review Bot
Comment 7 2012-09-27 00:57:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.