Bug 97682 - [Chromium] Use ipafont instead of kochi-font on Linux DRT
Summary: [Chromium] Use ipafont instead of kochi-font on Linux DRT
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kenichi Ishibashi
URL:
Keywords:
Depends on:
Blocks: 97676
  Show dependency tree / graph
 
Reported: 2012-09-26 07:24 PDT by Kenichi Ishibashi
Modified: 2013-04-15 08:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (deleted)
2012-09-26 08:53 PDT, Kenichi Ishibashi 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kenichi Ishibashi 2012-09-26 07:24:23 PDT 
As a part of https://bugs.webkit.org/show_bug.cgi?id=97676, I'd like to switch Japanese font on Linux DRT from kochi-fonts to ipafont.

In layout tests, kochi-mincho is used to render Japanese text. However, kochi mincho doesn't have vhea/vmtx table so it's not feasible for vertical text tests. This causes regressions with a WIP patch for bug 97676 because the patch assumes that the font have correct vertical metrics. (FontSkia.cpp also has the same assumption)

ipafont has vhea/vmtx tables so I'd like to propose using ipafont instead of kochi font on Linux DRT. I think the benefit of bug 97676 is over supporting broken font (kochi-mincho). The WIP patch of bug 97676 will also fix bug 62841.
Comment 1 Kenichi Ishibashi 2012-09-26 07:29:14 PDT 
Tony, what do you think? If it's ok, I'll revise http://code.google.com/p/chromium/wiki/LinuxBuildInstructionsPrerequisites and build/install-build-deps.sh too.
Comment 2 Kenichi Ishibashi 2012-09-26 08:53:21 PDT 
Created attachment 165815 [details]
Patch

Not sure but webkit-patch doesn't work. uploading a patch by hand.
Comment 3 Tony Chang 2012-09-26 11:53:12 PDT 
What font do most Linux users in Japan use?  For example, which fonts are installed by default by Ubuntu 12.04 when installing the Japanese language support?

Using any font for the tests is fine, but we should try to use the most popular font.  I forget how I picked kochi-mincho.

Here's how we switch to a different font:
- We need to update install-build-deps.sh to install the new font.
- Install the new font on the Linux the bots.
- Update Tools/DumpRenderTree/chromium/TestShellX11.cpp to use the new font and update the baselines.
- Remove the old fonts from install-build-deps.sh.
Comment 4 Kenichi Ishibashi 2012-09-26 16:30:45 PDT 
(In reply to comment #3)
> What font do most Linux users in Japan use?  For example, which fonts are installed by default by Ubuntu 12.04 when installing the Japanese language support?

I found a proposal page that suggests VL gothic has the highest priority:
http://wiki.debian.org/Fonts/JapanesefontpkgProposal

Unfortunately, VL gothic doesn't have vhea/vmtx.

I searched the web and realized that kochi fonts are still used as default fonts in some cases. I think most of Japanese users don't use kochi fonts as default font these days because it's a low quality font compared with other fonts. However, it seems that we need to keep using kochi fonts because we can't assume that most users have a font which contains vhea/vmtx table.