SSIA
Created attachment 165788 [details] Patch
Comment on attachment 165788 [details] Patch Clearing flags on attachment: 165788 Committed r129647: <http://trac.webkit.org/changeset/129647>
All reviewed patches have been landed. Closing bug.
And an unreviewed buildfix landed in https://trac.webkit.org/changeset/129655 Reordering was incorrect in platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp and it caused build fail on our WK2 bot. See the log for details: http://build.webkit.sed.hu/builders/x86-64%20Linux%20Qt%20Release%20WebKit2%20%28Amazon%20EC2%29/builds/9147 Unfortunately EWS didn't notice it, because config test of libxcomposite failed for some reason (will be checked) and building of GraphicsSurfaceGLX.cpp was switched off by the buildsystem of QtWebKit automatically.
Just a note: "// Qt headers must be included before glx headers." comment in this file must have been suspicious a little bit. :)
(In reply to comment #5) > Just a note: "// Qt headers must be included before glx headers." comment in > this file must have been suspicious a little bit. :) Yeah noticed that comment now :-) thanks... anyway maybe they should be grouped together then. Also why didnt this fail on EWS qt-wk2?
(In reply to comment #6) > (In reply to comment #5) > > Just a note: "// Qt headers must be included before glx headers." comment in > > this file must have been suspicious a little bit. :) > > Yeah noticed that comment now :-) thanks... anyway maybe they should be grouped together then. Also why didnt this fail on EWS qt-wk2? Because libxcomposite-dev package is missing on it and on all of our server, except the 64 bit WK2 buildbot. We should add it our meta package as dependency.