Bug 97668 - Gesture tap highlighting entire first line
Summary: Gesture tap highlighting entire first line
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 420+
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-26 05:51 PDT by Allan Sandfeld Jensen
Modified: 2012-09-26 07:35 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.42 KB, patch)
2012-09-26 05:52 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2012-09-26 05:51:06 PDT 
On platforms using the GestureTapHighlighter in WebCore/page/GestureTapHighlighter, and tapping a link that is spread over two lines but where there the lower and upper line of the link touches, the gesture highligther will return path that includes the entire width of the first line.

The problem is the code ends up treating the first part of the highlight as if was a middle part when adding the last part.
Comment 1 Allan Sandfeld Jensen 2012-09-26 05:52:59 PDT 
Created attachment 165776 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-26 07:35:28 PDT 
Comment on attachment 165776 [details]
Patch

Clearing flags on attachment: 165776

Committed r129643: <http://trac.webkit.org/changeset/129643>
Comment 3 WebKit Review Bot 2012-09-26 07:35:31 PDT 
All reviewed patches have been landed.  Closing bug.