Bug 97663 – [BlackBerry] [DRT] Skip region of interest zooming when running DRT

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Xiaobo Wang]

Region of interest mechanism is preventing eventSender.mouseMoveTo() from working correctly.
DRT test fast/forms/textarea-scrolled-endline-caret.html failed for this reason.
When we set focus on the textarea control, it was automatically zoomed in (scaleFactor == 2) by the region of interest mechanism. When we call eventSender.mouseMoveTo(), the point was transformed back, so position (90, 20) became (45, 10), mouse was moved to the wrong place.

Should disable automatic zooming for DRT.

[Xiaobo Wang]

Created attachment 165772 [details]
patch

[Rob Buis]

Comment on attachment 165772 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165772&action=review

R- because it can be done cleaner.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:1073
> +#endif

The fix itself is good. But can you make a helper method for this, and put it in Api/BlackBerryGlobal? There is also one place in WebPage.cpp which does something like the above, you can use the new function there too.

[Xiaobo Wang]

Created attachment 165970 [details]
patch revision 1

How about this?

[WebKit Review Bot]

Attachment 165970 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BlackBerryGlo..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.cpp:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rob Buis]

Comment on attachment 165970 [details]
patch revision 1

View in context: https://bugs.webkit.org/attachment.cgi?id=165970&action=review

Better to have isRunningDrt with a simpler implementation, looks good otherwise.

> Source/WebKit/blackberry/Api/BlackBerryGlobal.cpp:164
> +#endif

I think this is overkill. Just calling getenv always should not be slow, and anyway the final release will not even call it but just return false here.

[Xiaobo Wang]

Created attachment 166129 [details]
patch revision 2

Make it simple.

[WebKit Review Bot]

Attachment 166129 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit/blackberry/Api/BlackBerryGlo..." exit_code: 1
Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.cpp:45:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Rob Buis]

Comment on attachment 166129 [details]
patch revision 2

Patch looks good but the style issue needs to be fixed.

[Xiaobo Wang]

Created attachment 168612 [details]
patch

Fixed style error in Source/WebKit/blackberry/WebKitSupport/DumpRenderTreeSupport.cpp and Source/WebKit/blackberry/Api/BlackBerryGlobal.h.

[Rob Buis]

Comment on attachment 168612 [details]
patch

LGTM.

[WebKit Review Bot]

Comment on attachment 168612 [details]
patch

Clearing flags on attachment: 168612

Committed r131326: <http://trac.webkit.org/changeset/131326>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.