Bug 97662 - Web Inspector: NMI: replace manual JS external resources counting with MemoryInstrumentation
Summary: Web Inspector: NMI: replace manual JS external resources counting with Memory...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Ilya Tikhonovsky
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-26 05:00 PDT by Ilya Tikhonovsky
Modified: 2012-09-26 08:21 PDT (History)
15 users (show)

See Also:


Attachments
Patch (16.08 KB, patch)
2012-09-26 05:06 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (12.12 KB, patch)
2012-09-26 06:04 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (22.18 KB, patch)
2012-09-26 06:49 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
Patch (21.41 KB, patch)
2012-09-26 06:51 PDT, Ilya Tikhonovsky
no flags Details | Formatted Diff | Diff
merge artefacts were removed (21.22 KB, patch)
2012-09-26 07:15 PDT, Ilya Tikhonovsky
yurys: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ilya Tikhonovsky 2012-09-26 05:00:06 PDT
EOM
Comment 1 Ilya Tikhonovsky 2012-09-26 05:06:32 PDT
Created attachment 165770 [details]
Patch
Comment 2 Yury Semikhatsky 2012-09-26 05:26:44 PDT
Comment on attachment 165770 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165770&action=review

> Source/WebCore/ChangeLog:10
> +        No new tests (OOPS!).

Please provide a meaningful change log entry.

> Source/WTF/wtf/ArrayBuffer.h:141
> +    void reportMemoryUsage(MemoryObjectInfo*) const;

We could implement this as an external function.
Comment 3 Ilya Tikhonovsky 2012-09-26 06:04:39 PDT
Created attachment 165778 [details]
Patch
Comment 4 Ilya Tikhonovsky 2012-09-26 06:49:17 PDT
Created attachment 165787 [details]
Patch
Comment 5 Ilya Tikhonovsky 2012-09-26 06:51:08 PDT
Created attachment 165789 [details]
Patch
Comment 6 Ilya Tikhonovsky 2012-09-26 07:10:21 PDT
(In reply to comment #2)
> (From update of attachment 165770 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165770&action=review
> 
> > Source/WebCore/ChangeLog:10
> > +        No new tests (OOPS!).
> 
> Please provide a meaningful change log entry.
> 
> > Source/WTF/wtf/ArrayBuffer.h:141
> > +    void reportMemoryUsage(MemoryObjectInfo*) const;
> 
> We could implement this as an external function.

done
Comment 7 Gyuyoung Kim 2012-09-26 07:14:26 PDT
Comment on attachment 165789 [details]
Patch

Attachment 165789 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14034443
Comment 8 Ilya Tikhonovsky 2012-09-26 07:15:55 PDT
Created attachment 165796 [details]
merge artefacts were removed
Comment 9 Ilya Tikhonovsky 2012-09-26 08:21:11 PDT
Committed r129649: <http://trac.webkit.org/changeset/129649>