Bug 97659 - Web Inspector: paint inspector overlay on a transparency layer
Summary: Web Inspector: paint inspector overlay on a transparency layer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Andrey Kosyakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-26 04:48 PDT by Andrey Kosyakov
Modified: 2012-12-17 23:15 PST (History)
16 users (show)

See Also:

Attachments
Patch (1.79 KB, patch)
2012-09-26 04:50 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2012-09-26 05:04 PDT, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Patch (1.71 KB, patch)
2012-12-14 10:03 PST, Andrey Kosyakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Kosyakov 2012-09-26 04:48:48 PDT 
Currently, in the accelerated compositing, the text within the overlay page is only properly rendered on a solid background. This apparently happens due to wrong compositing operation being used when painting the view.
Comment 1 Andrey Kosyakov 2012-09-26 04:50:35 PDT 
Created attachment 165767 [details]
Patch
Comment 2 Build Bot 2012-09-26 04:54:42 PDT 
Comment on attachment 165767 [details]
Patch

Attachment 165767 [details] did not pass mac-ews (mac):
Output: http://queues.webkit.org/results/14027485
Comment 3 WebKit Review Bot 2012-09-26 04:55:32 PDT 
Comment on attachment 165767 [details]
Patch

Attachment 165767 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14033398
Comment 4 Gyuyoung Kim 2012-09-26 04:55:41 PDT 
Comment on attachment 165767 [details]
Patch

Attachment 165767 [details] did not pass efl-ews (efl):
Output: http://queues.webkit.org/results/14032427
Comment 5 Early Warning System Bot 2012-09-26 04:57:13 PDT 
Comment on attachment 165767 [details]
Patch

Attachment 165767 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14035391
Comment 6 Peter Beverloo (cr-android ews) 2012-09-26 05:00:11 PDT 
Comment on attachment 165767 [details]
Patch

Attachment 165767 [details] did not pass cr-android-ews (chromium-android):
Output: http://queues.webkit.org/results/14030455
Comment 7 kov's GTK+ EWS bot 2012-09-26 05:01:04 PDT 
Comment on attachment 165767 [details]
Patch

Attachment 165767 [details] did not pass gtk-ews (gtk):
Output: http://queues.webkit.org/results/14033400
Comment 8 Andrey Kosyakov 2012-09-26 05:04:14 PDT 
Created attachment 165769 [details]
Patch
Comment 9 Andrey Kosyakov 2012-09-26 07:05:45 PDT 
Committed r129633: <http://trac.webkit.org/changeset/129633>
Comment 10 Andrey Kosyakov 2012-09-27 05:15:57 PDT 
Reverted r129633 for reason:

Breaks inspector overlay in non-composited mode

Committed r129755: <http://trac.webkit.org/changeset/129755>
Comment 11 Andrey Kosyakov 2012-09-27 05:55:45 PDT 
(In reply to comment #10)
> 
> Committed r129755: <http://trac.webkit.org/changeset/129755>

Landed a fix at r129757: http://trac.webkit.org/changeset/129757
Comment 12 Andrey Kosyakov 2012-12-14 07:36:48 PST 
Reverted r129633 for reason:

Causes performance regression whn inspector overlay is displayed

Committed r137744: <http://trac.webkit.org/changeset/137744>
Comment 13 Andrey Kosyakov 2012-12-14 10:03:32 PST 
Created attachment 179494 [details]
Patch
Comment 14 WebKit Review Bot 2012-12-17 23:15:24 PST 
Comment on attachment 179494 [details]
Patch

Clearing flags on attachment: 179494

Committed r137989: <http://trac.webkit.org/changeset/137989>
Comment 15 WebKit Review Bot 2012-12-17 23:15:29 PST 
All reviewed patches have been landed.  Closing bug.