Bug 97640 - Rename ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
Summary: Rename ENABLE_INPUT_TYPE_TIME_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: yosin
URL:
Keywords:
Depends on:
Blocks: 97299 97633
  Show dependency tree / graph
 
Reported: 2012-09-26 00:26 PDT by yosin
Modified: 2012-09-27 18:25 PDT (History)
8 users (show)

See Also:

Attachments
Patch 1 (34.01 KB, patch)
2012-09-26 01:43 PDT, yosin 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description yosin 2012-09-26 00:26:28 PDT 
We would like to rename ENABLE_INPUT_TYPE_MULTIPLE_FIELDS to ENABLE_INPUT_MULTIPLE_FIELDS_UI to apply other date/time input types.
Comment 1 yosin 2012-09-26 01:43:15 PDT 
Created attachment 165750 [details]
Patch 1
Comment 2 yosin 2012-09-26 01:44:04 PDT 
Comment on attachment 165750 [details]
Patch 1

Could you review this patch?
Thanks in advance.
Comment 3 Kent Tamura 2012-09-26 01:57:12 PDT 
Comment on attachment 165750 [details]
Patch 1

ok
Please make sure this patch doesn't break any build and any tests.
Comment 4 yosin 2012-09-26 02:01:30 PDT 
Comment on attachment 165750 [details]
Patch 1

Clearing flags on attachment: 165750

Committed r129612: <http://trac.webkit.org/changeset/129612>
Comment 5 yosin 2012-09-26 02:01:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Kent Tamura 2012-09-26 02:02:55 PDT 
Please update http://trac.webkit.org/wiki/FeatureFlags
Comment 7 Kent Tamura 2012-09-27 18:09:21 PDT 
(In reply to comment #6)
> Please update http://trac.webkit.org/wiki/FeatureFlags

ping
Comment 8 yosin 2012-09-27 18:17:50 PDT 
(In reply to comment #7)
> (In reply to comment #6)
> > Please update http://trac.webkit.org/wiki/FeatureFlags
> 
> ping

I updated the wiki.
Comment 9 Kent Tamura 2012-09-27 18:21:20 PDT 
(In reply to comment #8)
> (In reply to comment #7)
> > (In reply to comment #6)
> > > Please update http://trac.webkit.org/wiki/FeatureFlags
> > 
> > ping
> 
> I updated the wiki.

Please remove INPUT_TYPE_TIME_MULTIPLE_FIELDS.  We don't need to keep a non-existing flag.
Comment 10 yosin 2012-09-27 18:25:14 PDT 
(In reply to comment #9)
> (In reply to comment #8)
> > (In reply to comment #7)
> > > (In reply to comment #6)
> > > > Please update http://trac.webkit.org/wiki/FeatureFlags
> > > 
> > > ping
> > 
> > I updated the wiki.
> 
> Please remove INPUT_TYPE_TIME_MULTIPLE_FIELDS.  We don't need to keep a non-existing flag.

Removed.