Bug 97634 - Removed ASSERT_CLASS_FITS_IN_CELL
Summary: Removed ASSERT_CLASS_FITS_IN_CELL
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Geoffrey Garen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-25 23:02 PDT by Geoffrey Garen
Modified: 2012-10-11 12:54 PDT (History)
9 users (show)

See Also:

Attachments
Patch (41.49 KB, patch)
2012-09-25 23:04 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (41.74 KB, patch)
2012-09-25 23:08 PDT, Geoffrey Garen 		no flags Details | Formatted Diff | Diff
Patch (29.53 KB, patch)
2012-10-11 12:38 PDT, Geoffrey Garen 		mhahnenberg: review+
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Geoffrey Garen 2012-09-25 23:02:01 PDT 
Removed ASSERT_CLASS_FITS_IN_CELL
Comment 1 Geoffrey Garen 2012-09-25 23:04:47 PDT 
Created attachment 165734 [details]
Patch
Comment 2 Geoffrey Garen 2012-09-25 23:08:41 PDT 
Created attachment 165735 [details]
Patch
Comment 3 Alexey Proskuryakov 2012-09-27 11:06:44 PDT 
Comment on attachment 165735 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165735&action=review

> Source/JavaScriptCore/ChangeLog:3
> +        Removed ASSERT_CLASS_FITS_IN_CELL

Rationale?

> Source/JavaScriptCore/ChangeLog:11
> +        * API/JSCallbackFunction.cpp:
> +        (JSC):
> +        * API/JSCallbackObject.cpp:
> +        (JSC):

Please remove the useless "(JSC):" lines.
Comment 4 Geoffrey Garen 2012-09-27 11:26:16 PDT 
> Rationale?

Our collector now supports arbitrarily sized objects, so the ASSERT is not needed.

> Please remove the useless "(JSC):" lines.

OK.
Comment 5 Geoffrey Garen 2012-10-11 12:38:02 PDT 
Created attachment 168260 [details]
Patch
Comment 6 Mark Hahnenberg 2012-10-11 12:49:24 PDT 
Comment on attachment 168260 [details]
Patch

r=me
Comment 7 Early Warning System Bot 2012-10-11 12:52:33 PDT 
Comment on attachment 168260 [details]
Patch

Attachment 168260 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/14249886
Comment 8 Geoffrey Garen 2012-10-11 12:54:26 PDT 
Committed r131088: <http://trac.webkit.org/changeset/131088>