Bug 97629 - http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after being unskipped
Summary: http/tests/security/cross-frame-access-put.html failing on Mac WK2 bots after...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Beth Dakin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-25 21:23 PDT by Beth Dakin
Modified: 2012-09-26 13:26 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.85 KB, patch)
2012-09-26 12:15 PDT, Beth Dakin
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2012-09-25 21:23:39 PDT
http/tests/security/cross-frame-access-put.html was a skipped test until http://trac.webkit.org/changeset/129486 

Now that is is unskipped, it is failing on the WK2 bots. It's possible that the failure is just a platform difference though since the test indicates that it is still passing. The diff is:

--- /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/http/tests/security/cross-frame-access-put-expected.txt
+++ /Volumes/Data/slave/lion-release-tests-wk2/build/layout-test-results/http/tests/security/cross-frame-access-put-actual.txt
@@ -520,9 +520,9 @@
 ALERT: PASS: window.personalbar should be '[object BarInfo]' and is.
 ALERT: PASS: window.plugins should be 'undefined' and is.
 ALERT: PASS: window.screen should be '[object Screen]' and is.
-ALERT: PASS: window.screenLeft should be '0' and is.
+ALERT: PASS: window.screenLeft should be '-10000' and is.
 ALERT: PASS: window.screenTop matched the expected value.
-ALERT: PASS: window.screenX should be '0' and is.
+ALERT: PASS: window.screenX should be '-10000' and is.
 ALERT: PASS: window.screenY matched the expected value.
 ALERT: PASS: window.scrollbars should be '[object BarInfo]' and is.
 ALERT: PASS: window.scrollX should be '0' and is.
Comment 1 Beth Dakin 2012-09-26 11:18:09 PDT
It looks like WebKitTestRunner is failing to use the fake window origin because _shouldUseFakeOrigin is NO when this test runs.  That doesn't seem right.
Comment 2 Tim Horton 2012-09-26 11:23:00 PDT
(In reply to comment #1)
> It looks like WebKitTestRunner is failing to use the fake window origin because _shouldUseFakeOrigin is NO when this test runs.  That doesn't seem right.

We should probably ditch _shouldUseFakeOrigin and just always use it (and initialize it to wherever we put the window initially).
Comment 3 Beth Dakin 2012-09-26 12:15:29 PDT
Created attachment 165849 [details]
Patch
Comment 4 Beth Dakin 2012-09-26 13:26:00 PDT
Thanks Tim! Committed change: http://trac.webkit.org/changeset/129694