Bug 97624 – [EFL][WK2] Some expected and actual parameters in unit tests are reversed

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit EFL

[Jinwoo Song]

According to the gtest guide, EXPECT_XXX(expected, actual) is recommended but some unit tests do not follow this.

http://code.google.com/p/googletest/wiki/Primer
"In the event of a failure, Google Test prints both val1 and val2 . In ASSERT_EQ* and EXPECT_EQ* (and all other equality assertions we'll introduce later), you should put the expression you want to test in the position of actual, and put its expected value in expected, as Google Test's failure messages are optimized for this convention."

[Jinwoo Song]

Created attachment 166198 [details]
Patch

[Raphael Kubo da Costa (:rakuco)]

Comment on attachment 166198 [details]
Patch

Looks harmless.

[Chris Dumez]

Comment on attachment 166198 [details]
Patch

Interesting. Looks good, thanks.

[Laszlo Gombos]

Comment on attachment 166198 [details]
Patch

r=me.

[WebKit Review Bot]

Comment on attachment 166198 [details]
Patch

Clearing flags on attachment: 166198

Committed r129892: <http://trac.webkit.org/changeset/129892>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[Sudarsana Nagineni (babu)]

This is causing a failure in API tests.

http://build.webkit.org/builders/EFL%20Linux%2064-bit%20Debug/builds/6521/steps/API%20tests/logs/stdio

/home/buildslave-1/webkit-buildslave/efl-linux-64-debug/build/Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:212: Failure
Value of: countHostnamesWithCookies(cookieManager)
  Actual: 0
Expected: 2
[  FAILED  ] EWK2UnitTestBase.ewk_cookie_manager_changes_watch (136 ms)

[Sudarsana Nagineni (babu)]

Comment on attachment 166198 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=166198&action=review

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:171
> +    ASSERT_EQ(ewk_context_ref(context), context);

This change is not needed.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:212
> +    ASSERT_EQ(2, countHostnamesWithCookies(cookieManager));

Expected value should be 0, not 2.

[Sudarsana Nagineni (babu)]

(In reply to comment #8)
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context.cpp:171
> > +    ASSERT_EQ(ewk_context_ref(context), context);
> 
> This change is not needed.
> 
> > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_cookie_manager.cpp:212
> > +    ASSERT_EQ(2, countHostnamesWithCookies(cookieManager));
> 
> Expected value should be 0, not 2.

These are now fixed in http://trac.webkit.org/changeset/129900
Thanks Raphael.

[Jinwoo Song]

Thanks for fixing, Raphael.