Bug 97623 – webkit-patch optimize-baselines should take a --platform arg

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dirk Pranke]

webkit-patch optimize-baselines should take a --platform arg

[Dirk Pranke]

Created attachment 165713 [details]
Patch

[Dirk Pranke]

posting for review, but see the comments in the changelog ... this isn't necessarily ready to land (or even a good idea).

Also, needs tests :).

[WebKit Review Bot]

Attachment 165713 [details] did not pass style-queue:

Traceback (most recent call last):
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 84, in <module>
    main()
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkit-patch", line 79, in main
    WebKitPatch(os.path.abspath(__file__)).main()
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/main.py", line 55, in __init__
    MultiCommandTool.__init__(self)
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/multicommandtool.py", line 221, in __init__
    self.commands = commands or [cls() for cls in self._find_all_commands() if cls.name]
  File "/mnt/git/webkit-style-queue/Tools/Scripts/webkitpy/tool/commands/rebaseline.py", line 185, in __init__
    AbstractRebaseliningCommand.__init__(self, options=port_options(platform='port/platform to use. Use glob-style wildcards for multiple ports'))
NameError: global name 'port_options' is not defined


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dirk Pranke]

This patch won't apply properly until the patch in bug 97621 is landed ...

[Csaba Osztrogonác]

Comment on attachment 165713 [details]
Patch

r-, because it killed the EWS

[Csaba Osztrogonác]

I filed a new bug report to make EWS can handle buggy patches too:
https://bugs.webkit.org/show_bug.cgi?id=97647

[Dirk Pranke]

Created attachment 172197 [details]
Patch

[Dirk Pranke]

Committed r133509: <http://trac.webkit.org/changeset/133509>