Bug 97609 - DelayNode must take sample-accurate delay times into account
Summary: DelayNode must take sample-accurate delay times into account
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Rogers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-25 15:05 PDT by Chris Rogers
Modified: 2012-09-26 12:06 PDT (History)
5 users (show)

See Also:

Attachments
Patch (5.63 KB, patch)
2012-09-25 15:13 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Patch (5.63 KB, patch)
2012-09-25 15:41 PDT, Chris Rogers 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Rogers 2012-09-25 15:05:38 PDT 
DelayNode must take sample-accurate delay times into account
Comment 1 Chris Rogers 2012-09-25 15:13:31 PDT 
Created attachment 165683 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-25 15:35:34 PDT 
Comment on attachment 165683 [details]
Patch

Attachment 165683 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14035188
Comment 3 Chris Rogers 2012-09-25 15:41:16 PDT 
Created attachment 165691 [details]
Patch
Comment 4 Kenneth Russell 2012-09-26 11:10:23 PDT 
Comment on attachment 165691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165691&action=review

Looks fine as far as I can tell. r=me. Would be nice to have a layout test.

> Source/WebCore/Modules/webaudio/DelayDSPKernel.cpp:116
> +        delayTime = max(0.0, delayTime);

Would be nice to have a templatized "clamp" primitive somewhere.
Comment 5 WebKit Review Bot 2012-09-26 12:06:17 PDT 
Comment on attachment 165691 [details]
Patch

Clearing flags on attachment: 165691

Committed r129681: <http://trac.webkit.org/changeset/129681>
Comment 6 WebKit Review Bot 2012-09-26 12:06:20 PDT 
All reviewed patches have been landed.  Closing bug.