RESOLVED FIXED 97597
CSP logging: Be more developer-friendly when 'default-src' is violated. 
https://bugs.webkit.org/show_bug.cgi?id=97597
Summary CSP logging: Be more developer-friendly when 'default-src' is violated.
Mike West
Reported 2012-09-25 12:38:28 PDT
It would be nice if we explained to developers that 'default-src' has effect on a wide variety of directives. See http://crbug.com/152181 for some context.
Attachments
Patch (8.45 KB, patch)
2012-09-25 13:54 PDT, Mike West 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mike West
Comment 1 2012-09-25 13:54:23 PDT
Created attachment 165663 [details] Patch
Mike West
Comment 2 2012-09-25 13:54:44 PDT
WDYT, Adam?
Adam Barth
Comment 3 2012-09-25 15:54:37 PDT
Comment on attachment 165663 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165663&action=review > Source/WebCore/page/ContentSecurityPolicy.cpp:893 > + suffix = " Note that 'script-src' was not explicitly set, so 'default-src' is used as a fallback."; is -> was ?
Adam Barth
Comment 4 2012-09-25 15:55:14 PDT
I'm not sure whether "is" or "was" is better. I figure you're a real-life writer and I just play one on bugzilla so you're probably right.
WebKit Review Bot
Comment 5 2012-09-25 16:20:04 PDT
Comment on attachment 165663 [details] Patch Clearing flags on attachment: 165663 Committed r129572: <http://trac.webkit.org/changeset/129572>
WebKit Review Bot
Comment 6 2012-09-25 16:20:07 PDT
All reviewed patches have been landed. Closing bug.
Mike West
Comment 7 2012-09-26 05:10:58 PDT
(In reply to comment #4) > I'm not sure whether "is" or "was" is better. I figure you're a real-life writer and I just play one on bugzilla so you're probably right. You figured wrong! I'm not sure if "is" is right here, really. It certainly shouldn't be the case that half the sentence is "was" and the other half "is". I don't think it's worth a patch on it's own, but next time I touch this stuff I'll change it too. Thanks!
Note You need to log in before you can comment on or make changes to this bug.