Bug 97580 - [GTK] Don't kill automatically the web process when the ui process finishes
Summary: [GTK] Don't kill automatically the web process when the ui process finishes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 97583
  Show dependency tree / graph
 
Reported: 2012-09-25 11:16 PDT by Carlos Garcia Campos
Modified: 2012-09-25 11:33 PDT (History)
0 users

See Also:

Attachments
Patch (1.84 KB, patch)
2012-09-25 11:19 PDT, Carlos Garcia Campos 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2012-09-25 11:16:31 PDT 
We use prctl(PR_SET_PDEATHSIG, SIGKILL); in linux to make sure the web process is killed when the ui process finishes. This is not needed any more since now the web process stops the main loop when the connection with the ui process is closed in WebProcess::didClose(). This approach is better because it works for any platform and makes the web process finish normally from the main().
Comment 1 Carlos Garcia Campos 2012-09-25 11:19:17 PDT 
Created attachment 165643 [details]
Patch
Comment 2 Martin Robinson 2012-09-25 11:29:40 PDT 
Comment on attachment 165643 [details]
Patch

Nice.
Comment 3 Carlos Garcia Campos 2012-09-25 11:33:43 PDT 
Committed r129533: <http://trac.webkit.org/changeset/129533>