Bug 97557 - Web Inspector: Remove resource() getter from UISourceCode.
Summary: Web Inspector: Remove resource() getter from UISourceCode.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vsevolod Vlasov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-25 05:13 PDT by Vsevolod Vlasov
Modified: 2012-09-26 05:52 PDT (History)
12 users (show)

See Also:


Attachments
Patch (20.33 KB, patch)
2012-09-25 05:15 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (32.60 KB, patch)
2012-09-25 05:26 PDT, Vsevolod Vlasov
no flags Details | Formatted Diff | Diff
Patch (20.25 KB, patch)
2012-09-25 09:38 PDT, Vsevolod Vlasov
pfeldman: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vsevolod Vlasov 2012-09-25 05:13:46 PDT
Resource could be fetched from ResourceTreeModel directly.
Comment 1 Vsevolod Vlasov 2012-09-25 05:15:22 PDT
Created attachment 165586 [details]
Patch
Comment 2 Vsevolod Vlasov 2012-09-25 05:26:50 PDT
Created attachment 165588 [details]
Patch
Comment 3 WebKit Review Bot 2012-09-25 05:59:04 PDT
Comment on attachment 165588 [details]
Patch

Attachment 165588 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14019124

New failing tests:
inspector/debugger/source-url-comment.html
Comment 4 Pavel Feldman 2012-09-25 07:18:47 PDT
Comment on attachment 165588 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165588&action=review

> Source/WebCore/ChangeLog:33
> +        Web Inspector: Provide a way to distinguish scripts having sourceURL from standalone scripts.

Dupe
Comment 5 Vsevolod Vlasov 2012-09-25 09:38:03 PDT
Created attachment 165631 [details]
Patch
Comment 6 Vsevolod Vlasov 2012-09-26 05:52:16 PDT
Committed r129626: <http://trac.webkit.org/changeset/129626>