Bug 97553 – [GTK] Add Undo / Redo method to WebKit2 GTK+ API

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Simon Pena]

[GTK] Add Undo / Redo method to WebKit2 GTK+ API

[Simon Pena]

Created attachment 165579 [details]
Patch

[WebKit Review Bot]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Martin Robinson]

Comment on attachment 165579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82
> + * webkit_web_view_can_execute_editing_command(). It's only possible
> + * to undo a command when it has been previously issued.

Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here?

[Simon Pena]

(In reply to comment #3)
> (From update of attachment 165579 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82
> > + * webkit_web_view_can_execute_editing_command(). It's only possible
> > + * to undo a command when it has been previously issued.
> 
> Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here?

I guess this is a language mistake from my side. I meant that you need to generate a command if you want to later undo it, and to generate a command you'll need some interaction.

[Martin Robinson]

(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 165579 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review
> > 
> > > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82
> > > + * webkit_web_view_can_execute_editing_command(). It's only possible
> > > + * to undo a command when it has been previously issued.

Maybe just say "It's only possible to undo a command after a previously executed editing operation."

I think that covers the case of the operation coming from either the WebKit API or the user.

[Simon Pena]

Created attachment 165613 [details]
Patch

[WebKit Review Bot]

Comment on attachment 165613 [details]
Patch

Clearing flags on attachment: 165613

Committed r129510: <http://trac.webkit.org/changeset/129510>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.