Bug 97553 - [GTK] Add Undo / Redo method to WebKit2 GTK+ API
Summary: [GTK] Add Undo / Redo method to WebKit2 GTK+ API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Pena
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-25 04:23 PDT by Simon Pena
Modified: 2012-09-25 08:18 PDT (History)
6 users (show)

See Also:

Attachments
Patch (3.03 KB, patch)
2012-09-25 04:25 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
Patch (3.04 KB, patch)
2012-09-25 07:49 PDT, Simon Pena 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pena 2012-09-25 04:23:40 PDT 
[GTK] Add Undo / Redo method to WebKit2 GTK+ API
Comment 1 Simon Pena 2012-09-25 04:25:12 PDT 
Created attachment 165579 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-25 04:27:08 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Martin Robinson 2012-09-25 06:36:15 PDT 
Comment on attachment 165579 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82
> + * webkit_web_view_can_execute_editing_command(). It's only possible
> + * to undo a command when it has been previously issued.

Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here?
Comment 4 Simon Pena 2012-09-25 06:44:20 PDT 
(In reply to comment #3)
> (From update of attachment 165579 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82
> > + * webkit_web_view_can_execute_editing_command(). It's only possible
> > + * to undo a command when it has been previously issued.
> 
> Is this strictly true? Doesn't undo also undo command issued by the user via interaction with a page or is that what you mean here?

I guess this is a language mistake from my side. I meant that you need to generate a command if you want to later undo it, and to generate a command you'll need some interaction.
Comment 5 Martin Robinson 2012-09-25 07:24:45 PDT 
(In reply to comment #4)
> (In reply to comment #3)
> > (From update of attachment 165579 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=165579&action=review
> > 
> > > Source/WebKit2/UIProcess/API/gtk/WebKitEditingCommands.h:82
> > > + * webkit_web_view_can_execute_editing_command(). It's only possible
> > > + * to undo a command when it has been previously issued.

Maybe just say "It's only possible to undo a command after a previously executed editing operation."

I think that covers the case of the operation coming from either the WebKit API or the user.
Comment 6 Simon Pena 2012-09-25 07:49:40 PDT 
Created attachment 165613 [details]
Patch
Comment 7 WebKit Review Bot 2012-09-25 08:18:29 PDT 
Comment on attachment 165613 [details]
Patch

Clearing flags on attachment: 165613

Committed r129510: <http://trac.webkit.org/changeset/129510>
Comment 8 WebKit Review Bot 2012-09-25 08:18:33 PDT 
All reviewed patches have been landed.  Closing bug.