Bug 97551 - Add tests for datalist UI for input type date
Summary: Add tests for datalist UI for input type date
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keishi Hattori
URL:
Keywords:
Depends on: 97645
Blocks: 96085
  Show dependency treegraph
 
Reported: 2012-09-25 04:19 PDT by Keishi Hattori
Modified: 2012-09-26 21:27 PDT (History)
3 users (show)

See Also:


Attachments
Patch (41.06 KB, patch)
2012-09-25 06:03 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (38.25 KB, patch)
2012-09-25 23:00 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (63.40 KB, patch)
2012-09-26 00:33 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (63.29 KB, patch)
2012-09-26 02:01 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff
Patch (63.36 KB, patch)
2012-09-26 20:32 PDT, Keishi Hattori
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keishi Hattori 2012-09-25 04:19:12 PDT
Add tests for datalist UI for input type date
Comment 1 Keishi Hattori 2012-09-25 06:03:58 PDT
Created attachment 165595 [details]
Patch
Comment 2 WebKit Review Bot 2012-09-25 06:54:01 PDT
Comment on attachment 165595 [details]
Patch

Attachment 165595 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14033050

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html
platform/chromium/fast/forms/date/date-suggestion-picker-key-operations.html
Comment 3 Kent Tamura 2012-09-25 20:14:09 PDT
Comment on attachment 165595 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165595&action=review

> LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:25
> +    <option label="-">2012-01-21</option>

What's the intention of this label="-"?

> LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:74
> +    <option>2012-03-08</option>
> +    <option>2012-01-00</option> <!--invalid-->
> +    <option>foo</option> <!--invalid-->

* I don't think we need such large number of options in this test. 20 + a few would be enough.
* Invalid options should be younger children in order to check whether they are omitted or not.
Comment 4 Keishi Hattori 2012-09-25 23:00:40 PDT
Created attachment 165733 [details]
Patch
Comment 5 Keishi Hattori 2012-09-25 23:01:19 PDT
(In reply to comment #3)
> (From update of attachment 165595 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165595&action=review
> 
> > LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:25
> > +    <option label="-">2012-01-21</option>
> 
> What's the intention of this label="-"?
Removed. It was there to mark page breaks.

> > LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-appearance.html:74
> > +    <option>2012-03-08</option>
> > +    <option>2012-01-00</option> <!--invalid-->
> > +    <option>foo</option> <!--invalid-->
> 
> * I don't think we need such large number of options in this test. 20 + a few would be enough.
> * Invalid options should be younger children in order to check whether they are omitted or not.

Done.
Comment 6 Kent Tamura 2012-09-25 23:10:41 PDT
Comment on attachment 165733 [details]
Patch

ok for these tests.

We should have other tests:
 - Appearance of hovered/selected suggestion
 - Appearance of the button with OtherDateLabel
 - Check if clicking the OtherDataLabel button switches the popup to CalendarPicker
Comment 7 Kent Tamura 2012-09-25 23:12:40 PDT
Comment on attachment 165733 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165733&action=review

> LayoutTests/platform/chromium/fast/forms/date/date-suggestion-picker-mouse-operations.html:156
> +    var offset = cumulativeOffset(element);
> +    var centerX = offset[0] + element.offsetWidth / 2;
> +    var centerY = offset[1] + element.offsetHeight / 2;
> +    eventSender.mouseMoveTo(centerX, centerY);

we can replace this with hoverOverElement(element).
Comment 8 Keishi Hattori 2012-09-26 00:33:33 PDT
Created attachment 165742 [details]
Patch
Comment 9 Kent Tamura 2012-09-26 01:01:40 PDT
Comment on attachment 165742 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165742&action=review

> LayoutTests/ChangeLog:10
> +        * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.

The picker width is slightly wider than the input width.  Is it expected?
Comment 10 Keishi Hattori 2012-09-26 02:01:09 PDT
Created attachment 165752 [details]
Patch
Comment 11 Keishi Hattori 2012-09-26 02:08:56 PDT
(In reply to comment #9)
> (From update of attachment 165742 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=165742&action=review
> 
> > LayoutTests/ChangeLog:10
> > +        * platform/chromium-mac/platform/chromium/fast/forms/date/date-suggestion-picker-appearance-expected.png: Added.
> 
> The picker width is slightly wider than the input width.  Is it expected?

It was a regression.

Modified the test so date-suggestion-picker-appearance.html is testing when the input width is wider than the suggestion width, date-suggestion-picker-appearance-with-scroll-bar.html is testing when suggestion width is wider than the input width.
Comment 12 Kent Tamura 2012-09-26 02:20:20 PDT
Comment on attachment 165752 [details]
Patch

looks good
Comment 13 WebKit Review Bot 2012-09-26 03:36:32 PDT
Comment on attachment 165752 [details]
Patch

Rejecting attachment 165752 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html
Full output: http://queues.webkit.org/results/14018479
Comment 14 WebKit Review Bot 2012-09-26 04:59:51 PDT
Comment on attachment 165752 [details]
Patch

Attachment 165752 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/14027489

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html
Comment 15 WebKit Review Bot 2012-09-26 19:55:13 PDT
Comment on attachment 165752 [details]
Patch

Rejecting attachment 165752 [details] from commit-queue.

New failing tests:
platform/chromium/fast/forms/date/date-suggestion-picker-appearance-with-scroll-bar.html
Full output: http://queues.webkit.org/results/14032651
Comment 16 Keishi Hattori 2012-09-26 20:32:43 PDT
Created attachment 165919 [details]
Patch
Comment 17 WebKit Review Bot 2012-09-26 21:27:23 PDT
Comment on attachment 165919 [details]
Patch

Clearing flags on attachment: 165919

Committed r129726: <http://trac.webkit.org/changeset/129726>
Comment 18 WebKit Review Bot 2012-09-26 21:27:28 PDT
All reviewed patches have been landed.  Closing bug.