setWillSendRequestReturnsNullOnRedirect() is currently not supported by WebKitTestRunner causing the following test to fail on WK2: http/tests/misc/will-send-request-returns-null-on-redirect.html
Created attachment 165566 [details] Patch
Comment on attachment 165566 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=165566&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1163 > + WKRetainPtr<WKURLRef> redirectURL = response ? adoptWK(WKURLResponseCopyURL(response)) : 0; is it possible that response==0 ? dumpResponseDescriptionSuitableForTestResult(response); was already invoked before, and there is no such check in it. > Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:203 > + bool willSendRequestReturnsNullOnRedirect() { return m_willSendRequestReturnsNullOnRedirect; } const ?
Comment on attachment 165566 [details] Patch Going to take Mikhail's feedback into consideration. Thanks.
Created attachment 165572 [details] Patch Take Mikhail's feedback into consideration.
Comment on attachment 165572 [details] Patch LGTM, thanks
Comment on attachment 165572 [details] Patch Clearing flags on attachment: 165572 Committed r129487: <http://trac.webkit.org/changeset/129487>
All reviewed patches have been landed. Closing bug.