Bug 97542 – [WK2][WKTR] TestRunner needs support for setWillSendRequestReturnsNullOnRedirect

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Chris Dumez]

setWillSendRequestReturnsNullOnRedirect() is currently not supported by WebKitTestRunner causing the following test to fail on WK2:
http/tests/misc/will-send-request-returns-null-on-redirect.html

[Chris Dumez]

Created attachment 165566 [details]
Patch

[Mikhail Pozdnyakov]

Comment on attachment 165566 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=165566&action=review

> Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:1163
> +    WKRetainPtr<WKURLRef> redirectURL = response ? adoptWK(WKURLResponseCopyURL(response)) : 0;

is it possible that response==0 ?

dumpResponseDescriptionSuitableForTestResult(response); was already invoked before, and there is no such check in it.

> Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:203
> +    bool willSendRequestReturnsNullOnRedirect() { return m_willSendRequestReturnsNullOnRedirect; }

const ?

[Chris Dumez]

Comment on attachment 165566 [details]
Patch

Going to take Mikhail's feedback into consideration. Thanks.

[Chris Dumez]

Created attachment 165572 [details]
Patch

Take Mikhail's feedback into consideration.

[Mikhail Pozdnyakov]

Comment on attachment 165572 [details]
Patch

LGTM, thanks

[WebKit Review Bot]

Comment on attachment 165572 [details]
Patch

Clearing flags on attachment: 165572

Committed r129487: <http://trac.webkit.org/changeset/129487>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.