Bug 97535 - DFG ArrayPush, ArrayPop don't handle clobbering or having a bad time correctly
Summary: DFG ArrayPush, ArrayPop don't handle clobbering or having a bad time correctly
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 97288
  Show dependency treegraph
 
Reported: 2012-09-25 00:35 PDT by Filip Pizlo
Modified: 2012-09-25 19:56 PDT (History)
7 users (show)

See Also:


Attachments
the patch (4.56 KB, patch)
2012-09-25 18:56 PDT, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (4.57 KB, patch)
2012-09-25 19:14 PDT, Filip Pizlo
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2012-09-25 00:35:18 PDT
I don't know what happened here.  They're just wrong.
Comment 1 Filip Pizlo 2012-09-25 18:56:27 PDT
Created attachment 165715 [details]
the patch

Test cases on the way.
Comment 2 Filip Pizlo 2012-09-25 19:14:23 PDT
Created attachment 165717 [details]
the patch
Comment 3 Filip Pizlo 2012-09-25 19:56:28 PDT
Landed in http://trac.webkit.org/changeset/129588