WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
97526
Bug in numeric accessors on global environment
https://bugs.webkit.org/show_bug.cgi?id=97526
Summary
Bug in numeric accessors on global environment
Gavin Barraclough
Reported
2012-09-24 22:53:10 PDT
I've hit this assert in test262 in browser, but haven't yet worked out how to repro in a test case :-/ The sparsemap is failing to map back from the global object to the window shell. A test case would need to resolve a numeric property name against the global environment.
Attachments
Fix
(2.11 KB, patch)
2012-09-24 22:55 PDT
,
Gavin Barraclough
ggaren
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Gavin Barraclough
Comment 1
2012-09-24 22:55:25 PDT
Created
attachment 165526
[details]
Fix
Geoffrey Garen
Comment 2
2012-09-24 23:03:07 PDT
To do an assignment directly to the global object, you need to do it lexically, and not using "this" or "window". Perhaps calling bare __defineSetter__() and __defineGetter__() with a numeric property will do it.
Geoffrey Garen
Comment 3
2012-09-24 23:03:37 PDT
Comment on
attachment 165526
[details]
Fix r=me
Gavin Barraclough
Comment 4
2012-09-24 23:10:59 PDT
(In reply to
comment #2
)
> To do an assignment directly to the global object, you need to do it lexically, and not using "this" or "window". Perhaps calling bare __defineSetter__() and __defineGetter__() with a numeric property will do it.
Sadly __defineSetter__/__defineGetter__ will replace the current getter/setter, rather than calling it. :-/ I need something equivalent to window[0] = foo; i.e. something that will do a [[Put]] rather than a [[DefineOwnProperty]], but where the base is the global environment. Still haven't worked out how to do this for a numeric name.
Gavin Barraclough
Comment 5
2012-09-24 23:38:13 PDT
Fixed in
r129458
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug