Bug 97518 - Add missing support for Geolocation tests on WebKit2
Summary: Add missing support for Geolocation tests on WebKit2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 21:20 PDT by Benjamin Poulain
Modified: 2012-09-25 12:06 PDT (History)
1 user (show)

See Also:

Attachments
Patch (28.74 KB, patch)
2012-09-24 21:33 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2012-09-24 21:20:02 PDT 
After r129444, we can add proper test support for WebKit2.
Comment 1 Benjamin Poulain 2012-09-24 21:33:58 PDT 
Created attachment 165515 [details]
Patch
Comment 2 Benjamin Poulain 2012-09-24 21:34:45 PDT 
Note: this adds new WebKit2 C API: WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage().
Comment 3 Sam Weinig 2012-09-25 00:50:22 PDT 
(In reply to comment #2)
> Note: this adds new WebKit2 C API: WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage().

Would it make sense to pass a WKErrorRef rather than a error message string?
Comment 4 Benjamin Poulain 2012-09-25 12:02:43 PDT 
> > Note: this adds new WebKit2 C API: WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage().
> 
> Would it make sense to pass a WKErrorRef rather than a error message string?

The only information we can give to the GeolocationAPI is a descriptive string. I think passing a string make this API simpler. We can alway extend later if needed.
Comment 5 Benjamin Poulain 2012-09-25 12:06:13 PDT 
Comment on attachment 165515 [details]
Patch

Clearing flags on attachment: 165515

Committed r129536: <http://trac.webkit.org/changeset/129536>
Comment 6 Benjamin Poulain 2012-09-25 12:06:16 PDT 
All reviewed patches have been landed.  Closing bug.