RESOLVED FIXED 97518
Add missing support for Geolocation tests on WebKit2 
https://bugs.webkit.org/show_bug.cgi?id=97518
Summary Add missing support for Geolocation tests on WebKit2
Benjamin Poulain
Reported 2012-09-24 21:20:02 PDT
After r129444, we can add proper test support for WebKit2.
Attachments
Patch (28.74 KB, patch)
2012-09-24 21:33 PDT, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2012-09-24 21:33:58 PDT
Created attachment 165515 [details] Patch
Benjamin Poulain
Comment 2 2012-09-24 21:34:45 PDT
Note: this adds new WebKit2 C API: WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage().
Sam Weinig
Comment 3 2012-09-25 00:50:22 PDT
(In reply to comment #2) > Note: this adds new WebKit2 C API: WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage(). Would it make sense to pass a WKErrorRef rather than a error message string?
Benjamin Poulain
Comment 4 2012-09-25 12:02:43 PDT
> > Note: this adds new WebKit2 C API: WKGeolocationManagerProviderDidFailToDeterminePositionWithErrorMessage(). > > Would it make sense to pass a WKErrorRef rather than a error message string? The only information we can give to the GeolocationAPI is a descriptive string. I think passing a string make this API simpler. We can alway extend later if needed.
Benjamin Poulain
Comment 5 2012-09-25 12:06:13 PDT
Comment on attachment 165515 [details] Patch Clearing flags on attachment: 165515 Committed r129536: <http://trac.webkit.org/changeset/129536>
Benjamin Poulain
Comment 6 2012-09-25 12:06:16 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.