RESOLVED FIXED Bug 97490
REGRESSION(r129346): It broke !ENABLE(INSPECTOR) build 
https://bugs.webkit.org/show_bug.cgi?id=97490
Summary REGRESSION(r129346): It broke !ENABLE(INSPECTOR) build
Csaba Osztrogonác
Reported 2012-09-24 15:40:05 PDT
build log from Qt minimal bot: ... /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::openInNewTab(WTF::String const&)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::windowObjectCleared()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::requestDetachWindow()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::sendMessageToBackend(WTF::String const&)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::frontendLoaded()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal(WebCore::InspectorController*, WebCore::Page*, WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings>)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorClient::doDispatchMessageOnFrontendPage(WebCore::Page*, WTF::String const&)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::requestAttachWindow()' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::moveWindowBy(float, float)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `typeinfo for WebCore::InspectorFrontendClientLocal' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight(unsigned int)' /ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `vtable for WebCore::InspectorFrontendClientLocal::Settings' ...
Attachments
Patch (1.58 KB, patch)
2012-09-25 00:22 PDT, Vivek Galatage 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vivek Galatage
Comment 1 2012-09-25 00:22:26 PDT
Created attachment 165537 [details] Patch
Csaba Osztrogonác
Comment 2 2012-09-25 00:31:32 PDT
Comment on attachment 165537 [details] Patch r=me
Csaba Osztrogonác
Comment 3 2012-09-25 00:33:15 PDT
Comment on attachment 165537 [details] Patch Clearing flags on attachment: 165537 Committed r129464: <http://trac.webkit.org/changeset/129464>
Csaba Osztrogonác
Comment 4 2012-09-25 00:33:20 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.