Bug 97490 - REGRESSION(r129346): It broke !ENABLE(INSPECTOR) build
Summary: REGRESSION(r129346): It broke !ENABLE(INSPECTOR) build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Blocker
Assignee: Vivek Galatage
URL:
Keywords:
Depends on:
Blocks: 90675
  Show dependency tree / graph
 
Reported: 2012-09-24 15:40 PDT by Csaba Osztrogonác
Modified: 2012-09-25 00:33 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.58 KB, patch)
2012-09-25 00:22 PDT, Vivek Galatage 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2012-09-24 15:40:05 PDT 
build log from Qt minimal bot:
...
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::openInNewTab(WTF::String const&)'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal()'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::windowObjectCleared()'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::requestDetachWindow()'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::sendMessageToBackend(WTF::String const&)'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::frontendLoaded()'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal(WebCore::InspectorController*, WebCore::Page*, WTF::PassOwnPtr<WebCore::InspectorFrontendClientLocal::Settings>)'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorClient::doDispatchMessageOnFrontendPage(WebCore::Page*, WTF::String const&)'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::requestAttachWindow()'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::moveWindowBy(float, float)'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `typeinfo for WebCore::InspectorFrontendClientLocal'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight(unsigned int)'
/ramdisk/qt-linux-release-minimal/build/WebKitBuild/Release/lib/libQtWebKit.so: undefined reference to `vtable for WebCore::InspectorFrontendClientLocal::Settings'
...
Comment 1 Vivek Galatage 2012-09-25 00:22:26 PDT 
Created attachment 165537 [details]
Patch
Comment 2 Csaba Osztrogonác 2012-09-25 00:31:32 PDT 
Comment on attachment 165537 [details]
Patch

r=me
Comment 3 Csaba Osztrogonác 2012-09-25 00:33:15 PDT 
Comment on attachment 165537 [details]
Patch

Clearing flags on attachment: 165537

Committed r129464: <http://trac.webkit.org/changeset/129464>
Comment 4 Csaba Osztrogonác 2012-09-25 00:33:20 PDT 
All reviewed patches have been landed.  Closing bug.