Bug 97479 – [Qt] Fix build with newer Qt 5

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[WebKit Review Bot]

http://trac.webkit.org/changeset/129343 broke the build:
It broke the build (Requested by Ossy_NIGHT on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear

[WebKit Review Bot]

Created attachment 165439 [details]
ROLLOUT of r129343

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.

[Csaba Osztrogonác]

Comment on attachment 165439 [details]
ROLLOUT of r129343

Clearing flags on attachment: 165439

Committed r129407: <http://trac.webkit.org/changeset/129407>

[Csaba Osztrogonác]

All reviewed patches have been landed.  Closing bug.

[Csaba Osztrogonác]

The original patch was rolled out, but I can't reopen the original bug, 
because there isn't bug report for this patch. In this case, I think, we
should use this bug to track this regression.

[Csaba Osztrogonác]

here is the build log:
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:32:37: error: private/qquickwebpage_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:33:37: error: private/qquickwebview_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:34:45: error: private/qwebiconimageprovider_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:35:39: error: private/qwebloadrequest_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:36:45: error: private/qwebnavigationrequest_p.h: No such file or directory

[Simon Hausmann]

(In reply to comment #4)
> The original patch was rolled out, but I can't reopen the original bug, 
> because there isn't bug report for this patch. In this case, I think, we
> should use this bug to track this regression.

Agreed. I'll adjust the title to reflect what this was actually trying to fix :)

[Simon Hausmann]

Created attachment 165547 [details]
Patch

[Simon Hausmann]

Same fix landed again with version guard

Committed r129471: <http://trac.webkit.org/changeset/129471>