Bug 97479 - [Qt] Fix build with newer Qt 5
Summary: [Qt] Fix build with newer Qt 5
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Review Bot
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-09-24 13:43 PDT by WebKit Review Bot
Modified: 2012-09-25 01:09 PDT (History)
4 users (show)

See Also:


Attachments
ROLLOUT of r129343 (2.70 KB, patch)
2012-09-24 13:43 PDT, WebKit Review Bot
no flags Details | Formatted Diff | Diff
Patch (3.02 KB, patch)
2012-09-25 00:55 PDT, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2012-09-24 13:43:16 PDT
http://trac.webkit.org/changeset/129343 broke the build:
It broke the build (Requested by Ossy_NIGHT on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Review Bot 2012-09-24 13:43:47 PDT
Created attachment 165439 [details]
ROLLOUT of r129343

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Csaba Osztrogonác 2012-09-24 13:47:26 PDT
Comment on attachment 165439 [details]
ROLLOUT of r129343

Clearing flags on attachment: 165439

Committed r129407: <http://trac.webkit.org/changeset/129407>
Comment 3 Csaba Osztrogonác 2012-09-24 13:47:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2012-09-24 13:50:14 PDT
The original patch was rolled out, but I can't reopen the original bug, 
because there isn't bug report for this patch. In this case, I think, we
should use this bug to track this regression.
Comment 5 Csaba Osztrogonác 2012-09-24 13:53:59 PDT
here is the build log:
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:32:37: error: private/qquickwebpage_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:33:37: error: private/qquickwebview_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:34:45: error: private/qwebiconimageprovider_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:35:39: error: private/qwebloadrequest_p.h: No such file or directory
/ramdisk/qt-linux-64-release/build/Source/WebKit/qt/declarative/plugin.cpp:36:45: error: private/qwebnavigationrequest_p.h: No such file or directory
Comment 6 Simon Hausmann 2012-09-25 00:54:41 PDT
(In reply to comment #4)
> The original patch was rolled out, but I can't reopen the original bug, 
> because there isn't bug report for this patch. In this case, I think, we
> should use this bug to track this regression.

Agreed. I'll adjust the title to reflect what this was actually trying to fix :)
Comment 7 Simon Hausmann 2012-09-25 00:55:56 PDT
Created attachment 165547 [details]
Patch
Comment 8 Simon Hausmann 2012-09-25 01:08:28 PDT
Same fix landed again with version guard

Committed r129471: <http://trac.webkit.org/changeset/129471>